Trading system being worked on...

joaoarena

  • Jr. Member
  • Posts: 99
  • Trades: 26
Re: Trading system being worked on...
« Reply #60, on April 25th, 2017, 07:45 PM »
Found out the problem with big big lists on offer: it shows wished, and then the ones not wished,  but does not take in account if we have the game or not. On barter, shows wished and not wished but not on library,  and then collapsed, all others that also are on owr library. Most people want not owned games, so, as it is, it is not very practical.
My real wishlist is on steam.
My wishlist here is for trading purposes.
I like to trade for games I do not own based on Want/Have Ratio, rather than other approaches.

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: Trading system being worked on...
« Reply #62, on April 25th, 2017, 08:08 PM »
Ah, yes... forgot to filter out library and blacklist games. Well I did a lot today so I'm allowed a bit of leeway ;)
I'll try to do that tonight... hopefully that won't hurt performance. Shouldn't. I mean, if barter does it quickly then why wouldn't I? That would be a first, ahah...

Small scrollbar: hmm... don't you have a mouse wheel..?
Can look into collapsing long lists too.

joaoarena

  • Jr. Member
  • Posts: 99
  • Trades: 26
Re: Trading system being worked on...
« Reply #63, on April 25th, 2017, 10:41 PM »Last edited on April 25th, 2017, 10:48 PM
Quote from Lestrade 尚 on April 25th, 2017, 08:08 PM
Small scrollbar: hmm... don't you have a mouse wheel..?
Not on my mobile, lol. But sweep with finger. I keep away long waiting times out of home by seeking trades :^^;:
Not that the size if the scroll matters hehehe. Long lists on a mobile are quite a problem.
Once you update, long long lists will not be a problem anymore.
Leeway-ing is good too ;)
My real wishlist is on steam.
My wishlist here is for trading purposes.
I like to trade for games I do not own based on Want/Have Ratio, rather than other approaches.

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: Trading system being worked on...
« Reply #64, on April 26th, 2017, 12:06 AM »
I'm surprised you're not complaining about the forced half-opacity effect on non-wishlisted items to make it clear that they're "less wanted"... ;)
It looks good, but it may not be too practical!
Re: Trading system being worked on...
« Reply #65, on April 26th, 2017, 12:19 AM »
Quick question: any custom trading tags you'd like me to add to the tag editor..?
It's very, very easy for me to add new tags, in any category (Trading, Tiers, etc.)

Also, I moved the Trading category to the top, so that 'may keep' and 'already used?' (some important and often used tags) can be accessed immediately. I also hid tags such as 'Pending trade' and 'Given Away', because frankly... I don't really see the point of these tags in a tradable copy..? (Do you?)

Akylen

  • Full Member
  • Posts: 218
  • Trades: 61
Re: Trading system being worked on...
« Reply #66, on April 26th, 2017, 02:15 AM »
The only thing I can remember is a custom tag for private notes, but it is not priority and I wouldn't know how much work is involved in that.

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: Trading system being worked on...
« Reply #67, on April 26th, 2017, 08:06 AM »
Already implemented at the same time as the store/quantity editor, but not enabled outside of me ;) mostly for policy reasons (I'll explain later.)

Akylen

  • Full Member
  • Posts: 218
  • Trades: 61
Re: Trading system being worked on...
« Reply #68, on April 29th, 2017, 03:36 PM »
Can you add an option to auto-remove items from the Wishlist if they are already in Library? I am not after extra copies and it is very frustrating having to do the removal manually all the time. Especially because there is no button to remove all of them at once.

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: Trading system being worked on...
« Reply #69, on April 29th, 2017, 05:13 PM »
What do you mean, do you have that many to remove..?
It's just one click per game (you don't even have to visit game pages for that, you can do it all from your wishlist page...)

joaoarena

  • Jr. Member
  • Posts: 99
  • Trades: 26
Re: Trading system being worked on...
« Reply #70, on April 29th, 2017, 06:12 PM »
I agree with  @akyleen, the norm is not to wish for the ones we already have. They should be removed automatically, and added only as extra wishlist for the ones who want doubles.
My real wishlist is on steam.
My wishlist here is for trading purposes.
I like to trade for games I do not own based on Want/Have Ratio, rather than other approaches.

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223

Akylen

  • Full Member
  • Posts: 218
  • Trades: 61

Pika! Pika!

  • Jr. Member
  • Posts: 52
  • Trades: 74

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: Trading system being worked on...
« Reply #74, on April 30th, 2017, 01:19 AM »
What do you mean?

@Akylen, I've spent my evening on this... It's not that it's hard to add a 'Delete all' button, it's that I wanted to do the entire operation in a single request, meaning I had to refactor my code to allow for multiple IDs to be passed (which I also need to later allow for mass tagging on list pages.)
Well, what a failure. It made everything more complicated-- my API went from ~30 lines of code up to 50. Thankfully it's just 50, eh..?
I also met a lot of bugs, I think I've tested for them all, but if you get an error while adding or removing something, or if the operation doesn't complete with the requested addition or removal, please be sure to PM me so I can look into it!
It's 1:20am here so I'm off to bed... Sorry I couldn't do more.