Trading system being worked on...

joaoarena

  • Jr. Member
  • Posts: 99
  • Trades: 26
Re: Trading system being worked on...
« Reply #46, on April 23rd, 2017, 02:49 PM »
When we try to remove the tradables copy #2, nothing happens and we get a blank page. had to remove copy #1 and update #2, that then become #1
My real wishlist is on steam.
My wishlist here is for trading purposes.
I like to trade for games I do not own based on Want/Have Ratio, rather than other approaches.

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 222
Re: Trading system being worked on...
« Reply #47, on April 23rd, 2017, 05:29 PM »
Oh, yes... I don't think that Remove button works like it should. I was busier making it work as a float (it didn't behave well), than handle the code AFTER it, lol. I think it removes the latest added game, rather than the current copy. Lemme fix that. :edit: Should be good now.

joaoarena

  • Jr. Member
  • Posts: 99
  • Trades: 26
Re: Trading system being worked on...
« Reply #48, on April 24th, 2017, 12:19 PM »
It works now, but when we click remove (in front), we are forwarded to the tradables section, instead of staying on the game. Feels awkward, because we have no confirmation that it was really removed, and we have to go back and refresh to confirm (or change other things in the game).
My real wishlist is on steam.
My wishlist here is for trading purposes.
I like to trade for games I do not own based on Want/Have Ratio, rather than other approaches.

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 222

joaoarena

  • Jr. Member
  • Posts: 99
  • Trades: 26
Re: Trading system being worked on...
« Reply #50, on April 24th, 2017, 05:39 PM »
about this accepted offer:
https://lestrades.com/offer/2498/

The game I have chosen should not bey grayed out. Both options are grey, there is no way to tell wich game was chosen.
I remember, when I have accepted the trade, to have received a warning telling me that the other user did not have those games on tradables. Cold that be the reason that caused tis issue?
My real wishlist is on steam.
My wishlist here is for trading purposes.
I like to trade for games I do not own based on Want/Have Ratio, rather than other approaches.

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 222
Re: Trading system being worked on...
« Reply #51, on April 24th, 2017, 06:26 PM »
Yes, that's the reason.
You're user 2.
User 1 offered two of his games.
Then he removed at least one from his tradables.
Then you accepted the offer. At this point, Lestrade's doesn't know what it 'should' see as the accepted games, making it possible that the trade will fail. In these situations you should contact user 1 by PM, ask them to re-add their games if they still have them and edit their offer, or cancel their offer.

BVG's way of doing this is 'simpler', it remembers games rather than tradables, meaning it's easier for it to 'recover' from such an error but also makes it possible for the offer to fail because for instance user 1 has an extra copy as a Steam gift and won't trade that copy for your game. See what I mean..?

I didn't get any feedback on my way of doing it, so I assumed it was best to do it that way. I could, of course, simply disable the Accept Offer button if an error is found in the trade offer like here... Or, alternatively, scan through their current tradables, try to find a newer tradable with the same characteristics to replace the old tradable, but that also means having to remember the store ID from the original offer... And... Well, meh..?

joaoarena

  • Jr. Member
  • Posts: 99
  • Trades: 26
My real wishlist is on steam.
My wishlist here is for trading purposes.
I like to trade for games I do not own based on Want/Have Ratio, rather than other approaches.

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 222

joaoarena

  • Jr. Member
  • Posts: 99
  • Trades: 26
My real wishlist is on steam.
My wishlist here is for trading purposes.
I like to trade for games I do not own based on Want/Have Ratio, rather than other approaches.

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 222

Akylen

  • Full Member
  • Posts: 218
  • Trades: 61

joaoarena

  • Jr. Member
  • Posts: 99
  • Trades: 26
Re: Trading system being worked on...
« Reply #58, on April 25th, 2017, 07:23 PM »
Now that is possible to offer or ask non wishlisted games, I have very very long offer pages. Is it possible to add a collapse button?
My real wishlist is on steam.
My wishlist here is for trading purposes.
I like to trade for games I do not own based on Want/Have Ratio, rather than other approaches.

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 222
Re: Trading system being worked on...
« Reply #59, on April 25th, 2017, 07:42 PM »
Non wishlisted items are limited to 200px on height, after which they get a scrollbar... isn't it your case? (Wishlisted items get 300px which is a bit more.)