[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: What's up at Lestrade's?
« Reply #585, on December 19th, 2017, 01:53 AM »
NEW: Added 'episode' and 'series' types to video items in the database. I've manually updated over 3.000 entries, so please forgive me if something is screwed up. The Walking Dead was a mess (as if the show itself wasn't already a mess by now...), it has more than 200 children (episodes, after-shows, docs...), and uses the same naming scheme as the Telltale games, so I ended up with lots of bugs which I had to fix manually, too. I'm scared now that when the BVG scraper comes back to these items, it'll screw them up again.

NEW: Search engine was updated to reflect that. '+video/-video' is now renamed to '+media/-media', and allows you to filter out videos + series + episodes. The 'video' tag is now only for regular videos (e.g. movies). Introduced 'series' and 'episode' tags, you know what they're for.
Re: What's up at Lestrade's?
« Reply #586, on December 20th, 2017, 01:51 AM »
I know you guys don't care, but I finally wrote myself a small script to be able to manually edit parents & children on game pages without having to manipulate the database. (It also updates, adds & removes the games to their parent of child.)

And needless to say, fixed countless games in the database manually. I haaaate that job...

Also, I have yet to see anyone comment on the mutual cancel feature. Did anyone test it...? You can obviously do a fake offer and cancel it. I just don't wanna do it myself.
Re: What's up at Lestrade's?
« Reply #587, on December 22nd, 2017, 06:26 PM »
NEW: Added an 'All games' link to the homepage... With which you can view the entire database, starting from newest additions. ;)
Re: What's up at Lestrade's?
« Reply #588, on December 24th, 2017, 06:17 PM »
NEW: All linked games will now show an icon in case you have wishlisted, blacklisted, owned them, or have it in your tradables. This might be a bit overwhelming in some areas, I'm disabling it on list pages (e.g. if you visit your wishlist, all items should have the wishlist icon, so they're implied and not shown, but icons like Tradable or Owned will still show up.)
I'll allow you to disable the option when I'm ready to rewrite profile options.
You may find some bugs here and there, in the form of duplicate icons. I'm currently in the process of removing icons where they were added automatically, but it takes a while, and pretty soon I'll be off to dinner (and I believe it's not a random dinner :P), and I'll hardly have time to finish fixing icons tonight, so please bear with me! I think it's great that I get to see these icons everywhere...
Re: What's up at Lestrade's?
« Reply #589, on December 24th, 2017, 10:11 PM »
FIX: Match page was showing tradable & wishlist icons in the 'expected place', so we had icons everywhere... I fixed it in a very smart way (seriously, I'm annoyingly proud of myself. I boasted to the missus about the simplicity of my solution.)
I think it's very interesting that you can now see owned items in your tradables. Really, really useful when considering whether to send an offer! (Owned items = less intimidating to retrade.)

/u/humpaaa

  • Full Member
  • ▶ ¦ Yep
  • Posts: 190
  • Trades: 10

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: What's up at Lestrade's?
« Reply #591, on December 26th, 2017, 05:02 PM »
New games are scraped off BVG (so that I can easily retain game IDs and associate them with tradables & wishlists when syncing user account data).
BVG gives these errors in various situations, most notably:
- When the game isn't released on Steam yet (but the Steam API started reporting it as existing, without much data),
- When the game was removed long ago from Steam, often out of a mistake (you can usually find data about them at SteamDB but they're often flagged as 'Unknown App ID' or something),
- When it's an episode of a TV show. (In which case, watch me have fun manually fixing all of the episodes... Yes, I do that regularly. It's like a full-time job for me.)

I chose not to 'hide' these entries from users, but I could just as easily do it if you prefer. Things like that, I call them 'internal soup'.
Re: What's up at Lestrade's?
« Reply #592, on December 27th, 2017, 12:04 AM »
FIX: Turned another few hundreds generic videos into series & episodes... Gosh this is just so annoying. It's made much easier by my new working method, but it's still a real hassle, like, I have to have 5 tabs open with 4 SQL queries ready to be tailored for a new discovered show, and another tab to navigate the game list and spot stuff that was 'forgotten'...
Also, I'm now pretty much convinced that BVG's association between series & episodes (over there it's called game & DLC, lol) is done manually by a regular user. They may want to work on Lestrade's instead, because it can be done with a few clicks :P

Anyway, if you find a lone episode not linked to its series, or a series/video/episode/etc. that's tagged as a game, please tell me so I can fix it!
There are now 7658 videos listed on the site. Including 271 TV shows and 6522 episodes. Which only leaves only 1136 'regular' videos (movies or whatever.)
Re: What's up at Lestrade's?
« Reply #593, on December 27th, 2017, 12:45 AM »
FIX: LT will no longer try to add icons to game names if there are over 2000 games sporting that icon on the page. This should be a decent enough number. Otherwise it just slows down the page loading for no reason. Also-- it's another argument for me to implement pagination on library pages, I guess!

PS: that's for @theemu, who's been hitting the server trying to update his tradable for the last hour. I don't know why he's so adamant on using the site to its full extent (look at his online stats), and yet never ever send/accept a single offer... :^^;: Maybe he just likes looking at game databases, I don't know. :P
Re: What's up at Lestrade's?
« Reply #594, on December 30th, 2017, 05:31 PM »
FIX: I've worked out an alternative layout where the sidebar is now forcibly shown at the bottom of the page. I like it because it's been a while since I haven't done some kind of horizontal sidebar, but I don't know about you, what do you guys think about it..? Likey, no likey? I can easily revert back to the old behavior if you prefer. Or maybe you just don't want to see all the extra information, I don't know. Maybe I can keep some of it (Quick access at least) to the homepage...

/u/humpaaa

  • Full Member
  • ▶ ¦ Yep
  • Posts: 190
  • Trades: 10

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: What's up at Lestrade's?
« Reply #597, on December 31st, 2017, 07:22 PM »
I actually reworked the sidebar to only show at the bottom if viewed on a mobile phone, as was intended. I will however mive it to the bottom on pages where it's currently hidden, like list pages. Just needs more work.

As for the search box it's a bit broken right now. I fixed your issue I suppose because I'm not seeing it on mobile at least. You still cant use search on mobile, unless you're looking for users. (An alternative is to search on steam and replace the steampowered text in the url with lestrades, a well known hack.)

I'll get to fixing all of that tomorrow, hopefully. Meanwhile, enjoy the festivities? ;)

/u/humpaaa

  • Full Member
  • ▶ ¦ Yep
  • Posts: 190
  • Trades: 10
Re: What's up at Lestrade's?
« Reply #598, on January 1st, 2018, 12:40 AM »
Yep, its fixed. Search icon is still a bit bugged, but at least the top bar extends all the way.
Happy New Year!

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: What's up at Lestrade's?
« Reply #599, on January 2nd, 2018, 11:00 PM »
FIX: Hopefully, I've fixed ALL issues I introduced these last few days with both the 'Preview offer' feature (this one should be OK, tested it on multiple devices, *and* I figured out what I was doing wrong, too), and with the quick search engine rewrite. The latter's rewrite was needed because mobile devices wouldn't show all of the options, so I replaced the usual type list with a dropdown, but it got messy real fast. (Notably, you couldn't search for games any more, then I fixed that, and it broke bundle search.) I just finished testing on my smartphone and my Opera, and it seems to be working great now.

Phew...