What's up at Lestrade's?


  • Full Member
  • ▶ ¦ Yep
  • Posts: 157
  • Trades: 7
Re: What's up at Lestrade's?
« Reply #465,  »
Quote from Lestrade 尚 on July 31st, 06:28 PM
FIX: Lestrade's will now probably remember your preference between Day & Night mode. Previously, there was a silly JavaScript error that got triggered right before saving your setting. Bad luck!
Probably? :P

Lestrade 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 968
  • Trades: 146
Re: What's up at Lestrade's?
« Reply #466,  »
Well... Never say never, as they say! ;)
I mean, fixing a bug usually means one hurdle is gone. But what if there were TWO bugs? ;)
Apparently not the case here, but still! ;)

(Woohoo, 700 posts... Okay, I've nearly posted half of the messages on this forum then... Most of them on this topic. :^^;:)
Re: What's up at Lestrade's?
« Reply #467,  »
FIX: Checkboxes in Day mode were too dim against the background. Added a subtle border around them. (Not needed in Night mode.)
Re: What's up at Lestrade's?
« Reply #468,  »
NEW: In match pages, inactivity status now clearly states how long someone has been absent. (If someone's been on vacation for 10 days now, it doesn't mean they have abandoned trading like users who haven't been online in 4 months.)
Note: I'm not showing it on mobile to save space. Although I foolishly decided to stuff the information into title tooltips, which is silly because, err, mobile devices usually don't support those...
Re: What's up at Lestrade's?
« Reply #469,  »
FIX: There was too much difference in colors between a (say) 12:11 ratio and a 11:12 ratio. Also fixed the intermediate colors from a mix between green and red (maroonish?) to gray. Which just makes more sense... This is only valid for Night mode-- I'm not too unhappy with Day mode regarding colors. (Yes, colors aren't the same in both modes; if you switch between day & night, you'll see the ratio colors are screwed up, which is one of the reasons I'm considering forcing a page reload when switching modes. Apart from the fact that it'll make my life easier when updating CSS...)
Re: What's up at Lestrade's?
« Reply #470,  »
FIX: A long-lived bug that caused trouble when adding games to one of your lists from a bundle page. The internal issue was caused by a variable overwriting itself during early processing.

NEW: Games added from a bundle will now be pre-selected when you're redirected to the corresponding list page. (And yes, if I hadn't planned to implement that, I wouldn't have found out the origin of the bug above.)
Re: What's up at Lestrade's?
« Reply #471,  »
NEW: Also, it sounds silly, but if games are pre-selected, the tagger popup should pop up now. It should also happen when bulk-adding items.

Note: I noticed a strange behavior in wishlist IDs growing exponentially (we're now into the 7-million mark, when it should be in the 300k mark IIRC). I thought it was a problem with my recent code that auto-deletes wishlisted items found in your library, and then re-adds them from BVG, but nope, I've established it started around late May, but couldn't find anything in my changelog that gave me a clue about it. I've added a bunch of trace lines here and there, so I should be able to determine if this is a bug on my side, or some user having fun adding & deleting their entire wishlist on a daily basis.
Re: What's up at Lestrade's?
« Reply #472,  »
NEW: Selectable games (i.e. with checkboxes) are now clickable anywhere on the row (e.g. including the card number, the ratio area...), which should be much more practical. I implemented that for offer creation lists, but is now available for all relevant list pages (tradables and wishlist).
Re: What's up at Lestrade's?
« Reply #473,  »
Quote from Lestrade 尚 on August 2nd, 02:07 PM
Note: I noticed a strange behavior in wishlist IDs growing exponentially (we're now into the 7-million mark, when it should be in the 300k mark IIRC).
Was due to Steam autosync... I had to remove a keyword and fix auto_increment on each run. Fixed and renumbered.
Took 2 days to pinpoint though... -_-
Re: What's up at Lestrade's?
« Reply #474,  »
FIX: PM area was broken in mobile browsers; avatar would use up the entire half left of the screen estate, leaving only a small space for PM contents. For some reason I'd disabled (for testing?) a CSS rule for them, and didn't reply a PM on my smartphone until today, I guess.
Re: What's up at Lestrade's?
« Reply #475,  »
FIX: Lestrade's was reporting missing tradables & wishlists on offers that were marked as Half-Completed by the other party. The absence of these items is as expected, it's the warning that was not.
Re: What's up at Lestrade's?
« Reply #476,  »
NEW: In game pages, if a game was bundled as part of a package, the package's name will be shown alongside the bundle name. For better service, I've also made sure to show the package colored by its ratio (similar to what you can see on Match pages.) This is in case a game's package is more common than the game itself.
Re: What's up at Lestrade's?
« Reply #477,  »
NEW: Bundles that have expired within the last week are now shown on the main bundle list, grayed out, at the end of the page. This is mostly because it's hard to find an expired bundle right now (other than by remembering one of the games that was in it.)
Re: What's up at Lestrade's?
« Reply #478,  »
FIX: $0 games weren't updated automatically. They used to be (daily) but I disabled that scheduled task while doing a test a few weeks ago. No biggie, I only 'missed' 47 entries overall that had been given away since the task was disabled.

FIX: Updated 684 games with missing trading card numbers.[1]

I'm also working on automating game card numbers without hitting on BVG's server any longer (back when I was scraping the whole site on a daily basis this wasn't a problem, but now that I'm limited to new games only, I'd never retrieve cards for them because they were added too late in the process over there, after I'd scraped them the first & final time.) The data for all 684 games was gotten from Steam instead of BVG, this includes one game that already had trading card data but the wrong number of cards -- Trigger Happy Shooting, in case the BVG admin is reading and wants to fix it (it's missing one card in the Steam list of items for that app ID for some reason, but the app's badge page has the extra card listed.)
Anyway, automating is more complicated than I expected, but I'm on it. I may miss a few games from time to time and have to fix them once in a while by re-scraping everything like I did. I don't know.
 1. Includes mostly games whose cards were added in the last 3-4 months (including older games like Baldur's Gate I & II), also a few, err, weird things like the movie 'Free to Play' which is on the game database and actually has cards as shown in its app ID's badge page, but they're not obtainable because it's a free movie. But I guess they're craftable through gem purchase, so I'm still going to let this kind of thing go. It's more of an issue with the database, where I don't know if it should hold free-to-play items (not tradable on Steam, but DLCs can be, so I guess I'll keep them around but I'd eventually like to mark them as free-to-play, and prevent them from being added to your Tradables, if only by mistake.)
Re: What's up at Lestrade's?
« Reply #479,  »
NEW: Trading card additions should now be automated, a few times per hour. (And, again, I'm no longer relying on BVG for this data, so there may be some discrepancies on recent games in the future.)