[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: What's up at Lestrade's?
« Reply #450, on July 20th, 2017, 06:55 PM »
NEW: When creating an offer, items that are in a pending offer (i.e. in another accepted, but not completed offer) will be grayed out with the [pending trade] mention. It's not exactly the same as the usual 'pending trade' tag, which is imported from Barter lists. Rather, the [pending trade] (with brackets) mention is based on a real-time check of other accepted offers on both sides.
I should probably improve this feature by not graying out the entry if its quantity is > 1, or indicating whose side the pending trade is on, who's the other trader in the pending trade, etc, but I feel it's good enough for now.
Re: What's up at Lestrade's?
« Reply #451, on July 21st, 2017, 01:09 AM »
FIX: On profile pages, the Steam avatar is now the proper size (I forgot to do that earlier. I mean, the proper size is 184px wide and the profile sidebar is 180px wide... And yet I didn't bother to just increase the sidebar size to 184px until now..?!)

FIX: On offer lists, I'm now only showing warnings (e.g. "this isn't in your tradables") on YOUR offer list. It's not a matter of privacy, simply of not being able to do anything about those missing games. It's not your problem, really :P

FIX; Fixed the 'Mark offer as completed' button showing up on all accepted offers-- even if not yours-- even if you're not logged into LT's!! I can't believe I never noticed it...

NEW: I'm currently working on hiding the sidebar by default, regardless of the page width, when you're on a content-heavy page, such as Wishlist/Tradables/Blacklist/Library/Offer-Creation.[1] Why? (1) more space to show those long tag lists! (2) the longer the page, the longer it takes for the sidebar to show up... And since it forces a reflow on your page layout, it means anything you clicked during the loading of the page will be incorrectly targeted, and may bring you to an outcome you didn't expect. (Yes, true story.)

Of course, you can still show the sidebar by clicking on the 'hamburger' icon at the very right end of the header bar.
Posted: July 21st, 2017, 12:57 AM

(Offer creation pages now hide the sidebar, too.)

I forgot to mention that I also reduced the maximum width of the window from 1420px down to 1280px-- and yes, I'm aware this pretty much cancels out the sidebar being hidden... Although not for smaller resolutions. Anyway... I'm still playing around with those width values.
 1. Currently working on all pages except for offer creation. Coming soon.
Re: What's up at Lestrade's?
« Reply #452, on July 21st, 2017, 12:16 PM »
NEW: Improved workflow for wishlist/library synergy...

- Press the Sync with Steam button on Wishlist or Library page.
- Once done, whether you're on your Wishlist *or* Library page, the same message will immediately show up, indicating the presence of duplicates.
- It will automatically remove them at this point; you have the ability to immediately re-add them with the + tag, or alternatively infinite quantity.
Re: What's up at Lestrade's?
« Reply #453, on July 21st, 2017, 03:49 PM »
NEW: Avatars in match pages.

Also, a detail on yesterday's changelog: when I said the 'Mark offer as completed' button showed up for guests, it doesn't mean clicking it did anything, of course... I always double-check credentials before I change anything to the database. I just don't always do it for the UI.
Re: What's up at Lestrade's?
« Reply #454, on July 21st, 2017, 04:10 PM »
NEW: a 'waiting' tag for tradables... This is mostly geared towards Happy Hour bundle buyers. So you can safely send offers using these games, and you have a wait to tell users, "this particular game, I'll send you within a week when I get my group-buy copy."
Re: What's up at Lestrade's?
« Reply #455, on July 21st, 2017, 07:38 PM »
Fixed forum & homepage in mobile mode having a sidebar on all the time... oops. Nobody uses mobile? ^^;
Re: What's up at Lestrade's?
« Reply #456, on July 25th, 2017, 12:18 PM »
FIX: if a bundle had no games in their 1st tier(s), the price for subsequent tiers with games was screwed up. (Hopefully this doesn't screw up older bundles, but it shouldn't.)
Re: What's up at Lestrade's?
« Reply #457, on July 25th, 2017, 12:28 PM »
NEW: Added 'link only' tag for wishlists. It indicates that you only want a retradable link for that entry (or a Steam gift)[1]. I could have used 'gift only', but I'd rather reserve that for a potential tag where you only want a Steam gift (I'm waiting to see if Steam gifts really take on some actual value in the future...)
 1. It's not enforced at offer creation time, because as with everything on Lestrade's I don't like to enforce stuff, just give strong hints that some stuff shouldn't be done. However, I should probably AT LEAST check whether the game being offered is actually a gift or link when it's got this tag on it... Opinions welcome.
Re: What's up at Lestrade's?
« Reply #458, on July 26th, 2017, 12:24 AM »
FIX: "Half-completed" status wasn't shown at the top of your offer list in some situations. Don't ask me, I'm not even sure. I just rewrote the whole code block for more simplicity.
Re: What's up at Lestrade's?
« Reply #459, on July 26th, 2017, 01:17 PM »
FIX: Newly registered users shouldn't be seeing Day mode anymore. (i.e., it defaults to Night mode for them; existing users will still be on Day mode if they didn't touch anything.)

FIX: non-Steam packages automatically imported from BVG didn't have a title. (e.g. "Humble Bundle Deep Silver BTA tier2 week1" or something... these aren't proper Steam packages.) I also added a 'generic package' category to put these in manually. (If I find any! I'm not gonna spend my day scanning Steam packages...)
@theemu, you're doing a great job of adding older bundles to BVG, but this screws up Lestrade's database, which already has all of the older bundles. Come to the dark side! Sorry, come to the night side!!

FIX: The search engine was unable to find many non-Steam-game items, like some packages.
Re: What's up at Lestrade's?
« Reply #460, on July 26th, 2017, 01:22 PM »
FIX: Removed 'Add to tradables' button on Bundle pages for guests... (Guys, do I have to do all the testing by myself? :P)
Re: What's up at Lestrade's?
« Reply #461, on July 27th, 2017, 11:16 PM »
FIX: Live update of tag changes on list pages was broken for a good week I think... Sorry about that, didn't notice before.
Re: What's up at Lestrade's?
« Reply #462, on July 31st, 2017, 06:28 PM »
FIX: Lestrade's will now probably remember your preference between Day & Night mode. Previously, there was a silly JavaScript error that got triggered right before saving your setting. Bad luck!

/u/humpaaa

  • Full Member
  • ▶ ¦ Yep
  • Posts: 190
  • Trades: 10
Re: What's up at Lestrade's?
« Reply #463, on July 31st, 2017, 07:58 PM »
Quote from Lestrade 尚 on July 31st, 2017, 06:28 PM
FIX: Lestrade's will now probably remember your preference between Day & Night mode. Previously, there was a silly JavaScript error that got triggered right before saving your setting. Bad luck!
Probably? :P

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: What's up at Lestrade's?
« Reply #464, on July 31st, 2017, 09:38 PM »
Well... Never say never, as they say! ;)
I mean, fixing a bug usually means one hurdle is gone. But what if there were TWO bugs? ;)
Apparently not the case here, but still! ;)

(Woohoo, 700 posts... Okay, I've nearly posted half of the messages on this forum then... Most of them on this topic. :^^;:)