[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,366
  • Trades: 219
Re: What's up at Lestrade's?
« Reply #240, on May 5th, 2017, 02:43 PM »
NEW: Ratio counter now handles 'infinity' differently: an infinite tradable copy counts for 10 copies (basically the most you can set on LT's, except it'll never drop), and an infinite wishlisted copy counts for just 1 copy.
I can be talked into changing these numbers, feel free to discuss.
As a quick note, it makes recounting twice slower than before, but hey... Gotta do what I gotta do. It's still super fast.

NEW: 'limited-time access' tag wasn't too explicit, I renamed it to 'will expire'. Also introduced a new tag next to it, 'must redeem', which is the other way around: a copy that will last forever, but must be redeemed quickly. (For instance, G2A bundles have these things, I think.)
Re: What's up at Lestrade's?
« Reply #241, on May 5th, 2017, 05:32 PM »
NEW: When creating offers, both trader lists are now shown side to side, rather than on top of each other. This makes it more natural to choose games on both sides. (And yes, I know I should show you on the right in keeping with how I show /matches/, but I couldn't convince myself to do it.)
Since it takes a lot of horizontal space, there are several levels of degradation depending on the window width. First the font size will be reduced, then the columns will be shown on top of each other (like before), then the font size will be reduced again (on mobile).
Hope you like it... I've been using that for a couple weeks without trouble.
Re: What's up at Lestrade's?
« Reply #242, on May 5th, 2017, 11:58 PM »
FIX: Offer creation page wasn't strict enough. From now on, if an item is in the trader's tradables, blacklist or library, there are 3 possibilities: either it's also in their wishlist (action: Lestrade's shows it grayed out, it's still selectable but it's an encouragement not to bother), or it's in their wishlist AND it has an extra (+) tag (action: Lestrade's shows it normally), or it's not in their wishlist (action: game is skipped entirely.)
That's a bit complicated but it's probably closer to what most traders would like. In the future I'll add profile settings to influence that behavior.

Also: I believe tag colors are now fixed in offer creation. Tags you see in blue (on both sides) were added by YOU, tags in gold were added by the other trader. Keep them in mind! Tag colors are still screwed up in /matches/ pages, though.

/u/humpaaa

  • Full Member
  • ▶ ¦ Yep
  • Posts: 189
  • Trades: 10
Re: What's up at Lestrade's?
« Reply #243, on May 6th, 2017, 01:08 AM »
1) Is it possible to remember the state of the "Show inactive traders in matches" checkbox?
I would love to have it always checked.

2) "The following items weren't found in your wishlist but you may wish to ask for them:" & "The following items weren't found in their wishlist but you may wish to offer them:"
--> Which games are shown here? Every game unowned by the other party? Random selection?

3) Great work on the latest updates :)

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,366
  • Trades: 219
Re: What's up at Lestrade's?
« Reply #244, on May 6th, 2017, 01:25 AM »
1/ yes but not for now. I'm waiting to implement profile settings.
2/ yes, all unowned, minus games in their tradables and blacklist.
3/ I know! Too bad half the user base left over time... it's like, guys gimme one month okay? They're not even giving me a week...

Ah well.
Btw I'm working on dual tags for match pages but it's hard. It kinda works but it's buggy (color coding sometimes fails) and matching queries are 0.05s slower due to how indexes are handled, and 0.4s slower (ouch!!) on single game matching pages (Matches link on game pages). I've got to a point where I don't know if I'm gonna keep dual tags.
Re: What's up at Lestrade's?
« Reply #245, on May 6th, 2017, 12:36 PM »
FIX: as I said above I'm working on dual tags for matches, which made querying slightly to much slower. I've fixed the 'much slower' on single game matching, if (and only if) the game you're looking for is already in your wishlist. If it's not, and you still want to match for it, the query will take over half a second, instead of being near-instantaneous.

I know, it's like saying I've bought a Ferrari because it saves me half a second on my way to the bakery, but speed is part of Lestrade's DNA. If I can improve a query, I'll do it.
Posted: May 6th, 2017, 12:23 PM

PS: the slowdown is only for using the 'Matches' link on game pages for games not in your wishlist. The 'Takers' link is as fast as ever.
Re: What's up at Lestrade's?
« Reply #247, on May 7th, 2017, 12:09 AM »
NEW: Another filter for premium users... List pages (wishlist, tradables, blacklist, library) now have a 'filter' dropdown where you can choose to filter out anything that's found (or NOT found) in another list. e.g., you can check your tradables, filter for 'Games in library', and see if there's any tradable you redeemed to yourself and forgot to remove.

I hope you enjoy it :)

(Well, I know, there are only 4 premium users at Lestrade's besides me, but in case you're wondering, my offer still holds, I still trade beta premium access for $2+ games. 'Not like I'm asking for too much :P)
Re: What's up at Lestrade's?
« Reply #248, on May 7th, 2017, 12:11 AM »
Oh, and.... This is my 400th post... and the 1000th post overall on the forum! On the same day we get to 1000 members! Just a few minutes after I got to 10 unique trades[1]! This is the day of rounded numbers, right?
 1. Okay, I have a lot of work and not much time to trade. :P
Re: What's up at Lestrade's?
« Reply #249, on May 7th, 2017, 01:43 AM »
FIX: Dual tags are now working properly on match pages.

What do I mean by dual tag..?

For instance, you can see this in a wished pane:

• Fallout 4 ▲, may keep ▼, +

This will mean, "the trader (who has it as a tradable) thinks it's a valuable game and he might keep his copy, while yourself (the one looking for it) considers it worth little to him, and only wants an extra copy, so this particular trade is very unlikely to ever happen.

In general:
- this is the color of a tradable or the trader looking to trade this item, In most situations, that's going to be you.
- and this is the color of a wished item, or the trader who's offering this copy.

If you have better color code suggestions, feel free to share!
Re: What's up at Lestrade's?
« Reply #251, on May 8th, 2017, 02:22 PM »
NEW: Matching is even faster. (You won't notice the difference.)

Remember when I said, a few posts above, that adding support for dual tags made matching 10% slower and about twice slower in special cases?
- Full match (600 wishlist, 300 tradables): 0.2s
- Match for a game not in my wishlist: 0.7s

So, this morning I decided to test alternative variations of my matching query... Here are the results:
- Memory usage: halved during query execution!
- Full match: 0.05s -- 4 times faster!
- Match for a game not in my wishlist: 0.04s -- 20 times faster!

Given that even the slowest matches are already lightning-fast, this is only going to be of interest to @devotee because he hosts the website, but at least it gives me assurance that the website will scale at least 3 times better when we get tons of users. :) In fact, it will probably scale better than 4 times better, because the second main reason[1] the query is faster is because I eliminated the filesort from the query, meaning LT doesn't have to create a temporary table to hold matching results before sorting them.

I'm pretty happy with the query as it is right now. I'm still using the 'old' version on the offer creation page, but I can always rewrite it later as well, in case it causes problems. (Which I doubt. We're talking about a 1:1 match here. Scalability issues are limited.)

PS: I rock!
 1. The first main reason it's faster is that I split the query in half, one for wished items and one for tradables, also the reason why memory usage is halved.

/u/humpaaa

  • Full Member
  • ▶ ¦ Yep
  • Posts: 189
  • Trades: 10

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,366
  • Trades: 219
Re: What's up at Lestrade's?
« Reply #253, on May 8th, 2017, 03:55 PM »
I just like optimizing!
I have to amend one of my numbers though-- matching for a non-wishlist item took around 0.4s when I tested, not 0.04s -- I didn't read the number correctly. So that's "only" twice faster than what it used to take. Since I posted my message, I've optimized that particular situation some more, and managed to get it to execute in less than 0.2s in average, so that's nearly 4 times faster now, similar to the full match speed gain (albeit not using the same optimization path at all).

Still, compared to my average 150 seconds on a certain other website, whether it's 0.1s or 0.2s doesn't really matter. ;)
Re: What's up at Lestrade's?
« Reply #254, on May 12th, 2017, 09:56 AM »
NEW: Manual syncing with Barter.vg!

Walkthrough:
- Go to any list page (wishlist, tradables, blacklist, library)
- Hit the 'Import from Barter.vg' button if your list is empty (you can move on to the next list and skip this guide...)
- Hit the 'Compare with Barter.vg' button if your list isn't empty.
- Lestrade's will retrieve your equivalent list on Barter, and show you two lists:

1/ Items found on Lestrade's but not on Barter.
2/ Items found on Barter but not on Lestrade's.

For each item, you have the ability to remove from Lestrade's (if applicable), add item & store & quantity & tags to Lestrade's (if applicable), or ignore (if it's a library item-- I'll add the Ignore flag to other lists if there's enough demand for it.) You can also, alternatively, view the item on Barter.vg to apply any changes over there manually (good luck...)
Unfortunately, I can't export items to Barter directly; I think I can export games but without any tags (I'd need to do some testing), so maybe you'd rather export them manually either way.

Oh, and there are also buttons that will allow you to add, remove or ignore all items at once. But I'd recommend using the individual links instead-- this would prevent any errors, and item manipulation is immediate.