« How to trade?
What's up at Lestrade's?
Is it just me or does it look like the beginning of the end… »

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: What's up at Lestrade's?
« Reply #60, on March 25th, 2017, 11:21 PM »
Remember that once you choose to add items manually, you lose the ability to import your stuff from Barter.
I can unlock it manually but I'm not going to do that on a regular basis. ^^

I'll have a look at importing from Barter again. It's obvious there's something wrong in my rewrite.
Also, Steam syncing will come at one point. (Steam library syncing is already written but I need to make sure it doesn't screw up everything; wishlist syncing needs to be written in the first place, but I guess I can reuse my library syncing code.)

NEW: https://lestrades.com/bundles/
It's just a placeholder page I added for joaoarena since I saw he attempted to visit that page. And yes I'd already accounted for that URL, just didn't have anything there. :P I'll work on it later, because right now it's ugly, but at least it shows you where the ITAD import is at. Basically, six months old for now :( I really need to catch up.

devotee

  • Newbie
  • Posts: 29
  • Trades: 14
Re: What's up at Lestrade's?
« Reply #61, on March 25th, 2017, 11:51 PM »
Quote from Nao 尚 on March 25th, 2017, 11:21 PM
Also, Steam syncing will come at one point. (Steam library syncing is already written but I need to make sure it doesn't screw up everything; wishlist syncing needs to be written in the first place, but I guess I can reuse my library syncing code.)
Ah, I was going to ask about it because I added a couple of games yesterday to my tradables, but I didn't remove them from my wishlist to check if they were automatically removed when a Steam library/wishlist sync was run. I saw today that they still are on my wishlist, so I thought about asking if Lestrades wasn't syncing with Steam, or if it was just that the sync hadn't been executed yet.
Quote from Nao 尚 on March 25th, 2017, 11:21 PM
It's just a placeholder page I added for joaoarena since I saw he attempted to visit that page.
I must confess I also checked that page before I wrote my post about bundles, hihihi :whistle:

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: What's up at Lestrade's?
« Reply #62, on March 26th, 2017, 12:53 AM »
BUG FIX: New users can FINALLY properly import their Barter lists.
This was tested with tservo2049 and confirmed working on all lists (wishlist, tradables, library, blacklist).

The error was all mine, I'd added a fail-safe test to allow myself to sync libraries for users requesting it (the 'I can do it manually for you' from above), but I'd put my test one line too early, where it wasn't valid at that point, and as such, everyone would get locked out of list importing (including my fail-safe).
There was one way to make it work though, through the use of a long-form URL, but it's no longer needed.

@devotee, wishlist syncing is something that scares me. I've got a nice horror story about the Steam game list that I regularly import (for later use), and at one point (back when I was on your server), I'd realized the unique index wasn't working well, and I'd ended up with a table that was like 20 times larger than what it should have been. ^^
Posted: March 25th, 2017, 11:57 PM

I noticed that since yesterday morning, isthereanydeal.com is no longer accessible to me. I'm getting timeouts. I've checked my firewall, etc, nothing special. I'm using the Google DNS servers mostly. Anyone else having trouble with them...? Is it specific to France?
I know there are people who still see the site. But it'll prove hard for me to retrieve the last 6 months worth of bundles at ITAD if I can't download the site's bundle list... ^^ (Okay, probably a VPN thing might work...)

devotee

  • Newbie
  • Posts: 29
  • Trades: 14
Re: What's up at Lestrade's?
« Reply #63, on March 26th, 2017, 01:12 AM »Last edited on March 26th, 2017, 01:14 AM
Quote from Nao 尚 on March 26th, 2017, 12:53 AM
I noticed that since yesterday morning, isthereanydeal.com is no longer accessible to me. I'm getting timeouts. I've checked my firewall, etc, nothing special. I'm using the Google DNS servers mostly. Anyone else having trouble with them...? Is it specific to France?
Works for me from home (Spain) and from two different servers hosted in France (OVH and Online). If you're doing many requests to ITAD you might want to use an API key or if you have contact with the ITAD owner, you could ask him if they would allow your IP (or the IP from the server hosting Lestrades) to be a little more aggressive than a regular user who would just browse their site.

Regarding the wishlist, should we manage it manually for now then (game page -> remove from wishlist)? Or would syncing the library (removing new items owned from the wishlist -if they are not tagged as 'extra'-) work?

CUE

  • Newbie
  • Posts: 4
  • Trades: 17
Re: What's up at Lestrade's?
« Reply #64, on March 26th, 2017, 11:41 AM »
Quote from Nao 尚 on March 26th, 2017, 12:53 AM
BUG FIX: New users can FINALLY properly import their Barter lists.
This was tested with tservo2049 and confirmed working on all lists (wishlist, tradables, library, blacklist).
Not for me:
- whislist empty, the import button redirects me to the barter blacklist
- tradables empty, the import button redirects me to the barter blacklist
- backlist empty, the import button redirects me to the barter blacklist (my list is empty)
- library OK

https://s25.postimg.org/c61x2mb3z/image.png

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: What's up at Lestrade's?
« Reply #65, on March 26th, 2017, 03:16 PM »
@devotee, I'm not talking about communication between LT and ITAD, that's working AFAIK (and yes I'm using the API with a key), I'm talking about myself here. I've tried with a VPN extension: German-based IP works, French-based IP fails, so I'm leaning towards routing problems (at the European level). What surprises me is that you say it's working on your server, since its traffic originates from the same sub-network as my own IP does...
Posted: March 26th, 2017, 03:12 PM

Re: wishlist, I noticed that I didn't get The Lost Crown removed from my wishlist after my latest trade, its quantity wasn't even down by 1. Do you mean it's the same for everyone..? Because it's supposed to be removed from your wishlist (or, at least, decreased in quantity-- that's the difference compared to Barter, I consider a wishlist in a trade to be immediately removable, whether or not you remove it; in order to acquire several copies you simply 'need' to set quantities on the wishlisted item-- when I enable tagging, obviously.) (Yes, I'd opened a parenthesis.)
Anyway, no, I'm not planning to have library syncing with Steam influence wishlist removal. However, I will definitely add a notice on Wishlist pages with a list of games that are found in your library and in your wishlist as well, so that you can remove them if you want. I'll need to remember that, though...
Re: What's up at Lestrade's?
« Reply #66, on March 26th, 2017, 03:20 PM »
@CUE, I'm not exactly sure why this wouldn't work for you. Please try again, I've added some code to let me check if your import failed or it is considered 'successful' by LT.
Also, it shouldn't redirect you to your blacklist page, unless you're importing your blacklist... ^^ The page where you land indicates what list you just tried to update.
Re: What's up at Lestrade's?
« Reply #67, on March 26th, 2017, 03:30 PM »
NEW/FIX: Now showing trading tags in game lists on offer pages. Previously they were only shown in the checkbox list while creating the offer. Which, granted, isn't very useful for the end user!
NEW: Barter icon on profile pages (previously it showed the link, but no icon.)
FIX: You can now keep your offers in 'creation' status for longer than your session's expiry date (they usually last a couple hours). I was checking for session data even while working on stuff that doesn't matter, so now I'm only checking it when submitting the offer. If you haven't touched your offer page in a while and want to submit it, make SURE to press the Preview button first, then check your offer's content, THEN press the Send button. This will save you from getting a 'session expired' error.
FIX: Since I'm no longer syncing with Barter, I've made it clear it's an 'import' now, if you're new to the site and you get to see the button.

(I should probably post those notices in a closed topic and have another topic to allow commenting on them... Otherwise it'll get confusing.)
Re: What's up at Lestrade's?
« Reply #68, on March 26th, 2017, 04:46 PM »
NEW: bundle pages now indicate whether you own a game or not. (Do you get where this is leading..? Yeah? Well it'll have to wait a bit longer, as I don't have time to complete the feature for now. :^^;:)

/u/humpaaa

  • Full Member
  • ▶ ¦ Yep
  • Posts: 190
  • Trades: 10
Re: What's up at Lestrade's?
« Reply #69, on March 26th, 2017, 05:17 PM »
Quote from Nao 尚 on March 26th, 2017, 04:46 PM
NEW: bundle pages now indicate whether you own a game or not. (Do you get where this is leading..? Yeah? Well it'll have to wait a bit longer, as I don't have time to complete the feature for now. :^^;:)
Could you do the same for blacklisted games? 

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223

/u/humpaaa

  • Full Member
  • ▶ ¦ Yep
  • Posts: 190
  • Trades: 10

Akylen

  • Full Member
  • Posts: 218
  • Trades: 61
Re: What's up at Lestrade's?
« Reply #72, on March 26th, 2017, 05:42 PM »
Quote from Nao 尚 on March 26th, 2017, 04:46 PM
NEW: bundle pages now indicate whether you own a game or not. (Do you get where this is leading..? Yeah? Well it'll have to wait a bit longer, as I don't have time to complete the feature for now. :^^;:)
The bundles URL should be visible. Maybe another tab for bundles? I am sure new users will miss this one out.

joaoarena

  • Jr. Member
  • Posts: 99
  • Trades: 26
My real wishlist is on steam.
My wishlist here is for trading purposes.
I like to trade for games I do not own based on Want/Have Ratio, rather than other approaches.

CUE

  • Newbie
  • Posts: 4
  • Trades: 17
Re: What's up at Lestrade's?
« Reply #74, on March 26th, 2017, 07:17 PM »
Quote from Nao 尚 on March 26th, 2017, 03:30 PM
Quote from Nao 尚 on March 26th, 2017, 03:20 PM
@CUE, I'm not exactly sure why this wouldn't work for you. Please try again, I've added some code to let me check if your import failed or it is considered 'successful' by LT.
Also, it shouldn't redirect you to your blacklist page, unless you're importing your blacklist... ^^ The page where you land indicates what list you just tried to update.
NEW/FIX: Now showing trading tags in game lists on offer pages. Previously they were only shown in the checkbox list while creating the offer. Which, granted, isn't very useful for the end user!
NEW: Barter icon on profile pages (previously it showed the link, but no icon.)
FIX: You can now keep your offers in 'creation' status for longer than your session's expiry date (they usually last a couple hours). I was checking for session data even while working on stuff that doesn't matter, so now I'm only checking it when submitting the offer. If you haven't touched your offer page in a while and want to submit it, make SURE to press the Preview button first, then check your offer's content, THEN press the Send button. This will save you from getting a 'session expired' error.
FIX: Since I'm no longer syncing with Barter, I've made it clear it's an 'import' now, if you're new to the site and you get to see the button.

(I should probably post those notices in a closed topic and have another topic to allow commenting on them... Otherwise it'll get confusing.)
Now work fine, thanks a lot :)
« How to trade?
Is it just me or does it look like the beginning of the end… »