Silyus

  • Newbie
  • Posts: 7
  • Trades: 5
Re: What's up at Lestrade's?
« Reply #45, on March 23rd, 2017, 05:16 PM »
Quote from Nao 尚 on March 23rd, 2017, 02:56 PM
I'm only trying to think of the far future. If we end up having millions of previous trade offers, with an average of 5-6 games per offer that'd mean quite a lot of rows in that table... Meaning potentially slower trade feature, too (although at this point I can either remove trades from over a year prior or something).
That's the reason I was suggesting to prune every offer older than a week. In this way you'll have only to deal with the number of trades done in a week, which will hardly reach 1M.
I was also suggesting to keep the trade history in a separate table so you don't have to load it every time an user want to look at their tradables (most of the time), but only when he wants to check his history (fairly rarely).
To be crystal clear, I'm just telling this only to defend the solution I proposed, not to push you in a specific direction.
Frankly I really appreciate the work you've done so far, also only you know how things are implemented, so feel free to implement the solution you think it's best (even considering how much more effort you want to put in this project).

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 222
Re: What's up at Lestrade's?
« Reply #46, on March 23rd, 2017, 08:04 PM »
Yep, no problem.
I've tested offers again and I'm still getting side issues, reason enough to postpone.
Never in my life have I postponed something day to day that much. Even the original opening of the website only took me 3 or 4 more says than initially announced... it's not easy redoing in a few days what barter took months to implement in the first place.

Maybe tonight though. I'll need testers in about an hour.

/u/humpaaa

  • Full Member
  • ▶ ¦ Yep
  • Posts: 190
  • Trades: 10

joaoarena

  • Jr. Member
  • Posts: 99
  • Trades: 26
My real wishlist is on steam.
My wishlist here is for trading purposes.
I like to trade for games I do not own based on Want/Have Ratio, rather than other approaches.

Quantum

  • Newbie
  • Posts: 30
  • Trades: 4
Re: What's up at Lestrade's?
« Reply #49, on March 23rd, 2017, 09:56 PM »Last edited on March 23rd, 2017, 10:03 PM
Option 2 sounds best for the future as it would allow all kinds of interesting data mining possibilities based on the tags that were on the tradeables (and allow historic viewing for users). To prevent performance / scaling issues I agree with Silyus that'd it'd be interesting to either make a separate table for tradeables in completed trades and / or to regularly run a script that moves completed tradeables older then i.e. a year to a separate database / storage location.

Purely for the initial startup I'd personally worry most about getting the database model right & not worry too much about these scaling issues yet as i.e. making a script to move tradeables older then a year to a separate database would be something that can be done afterwards / sliced from the initial release. Changing the database model however is always very annoying.

Note: Barter only has 90.000 complete offers in 2 years & 500.000 completed offers. In that sense a week seems very short. Which is why I mentioned a year here.

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 222
Re: What's up at Lestrade's?
« Reply #50, on March 24th, 2017, 01:02 PM »
A week would be way too short, yes.
A year makes more sense, anything beyond six months to be is just digging into nostalgia. ;)

BUG FIX: users weren't able to vote in polls. Oops.
Re: What's up at Lestrade's?
« Reply #51, on March 25th, 2017, 12:12 AM »
Fix/Addition: Offers where one (or both) side(s) have a '1 out of 4', '3 out of 5' or whatever but no '5 out of 5' choice, will always keep their checkbox next to items, to make it more obvious that it's not a 5 out of 5 offer. That is, you'll still have to look at the '3 of the 4 items below' or whatever to see how many items are requested/offered, but alternatively if you don't see the checkboxes, you'll know that all items are being offered.

Bug fix: if clicking multiple times on 'Add to (list)', you could end up with multiple copies in your list. Now the button will be silently disabled as soon as you click it. I'll probably do that on more items, like 'Accept offer' or whatever.
Posted: March 24th, 2017, 10:39 PM

Okay, I disabled the disabling of buttons. (Yeah that's nearly funny.)
The problem is that disabled buttons don't submit a value. So if there are multiple submit buttons in the same form, LT will be unable to know which was clicked. This made it impossible to send an offer... :(

I'll look into it a bit more.
Posted: March 24th, 2017, 11:25 PM

Okay, that was a nasty one, but it should work now. Double-submit prevented, and no features appear to be broken. Please tell me ASAP if you find something broken when clicking a button!
Re: What's up at Lestrade's?
« Reply #52, on March 25th, 2017, 12:37 AM »
Feature I forgot to mention: go to /search/ manually to search posts on the forum.

NEW FEATURE: new users (and only them) should now be able to import their Barter lists. If you added items manually to your lists, please remove them first, to avoid duplicate entries.
Needs testing! Because obviously I'm not a new user... ^^ It only took a dozen lines of code and I've read it multiple times, it shouldn't cause any issues.

/u/humpaaa

  • Full Member
  • ▶ ¦ Yep
  • Posts: 190
  • Trades: 10

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 222
Re: What's up at Lestrade's?
« Reply #54, on March 25th, 2017, 11:56 AM »
Congrats ;)

BUG FIX: Problems with new users being unable to import their lists from Barter.
You can now simply go to your Wishlist, Tradables, Blacklist or Library, and you should find a 'Sync from Barter.vg' button. Click it, wait, and there you go, your list is on Lestrade's with tags and all.

@Alex, I think you can safely reset the memory limit to 200M. My math is now done on a 250KB PHP file that contains a hardcoded array with all Steam IDs and corresponding Barter URLs. Really, it couldn't be simpler and faster to process. Heck, it's not even the biggest PHP file in Wedge. ;)
Re: What's up at Lestrade's?
« Reply #55, on March 25th, 2017, 02:53 PM »
NEW: when you receive an offer notification in the top-left corner, whether accepted, declined or whatever, click the notification (not the link) to show a preview of it, without leaving your current page. :)

Zyon

  • Newbie
  • Posts: 1
  • Trades: 7
Re: What's up at Lestrade's?
« Reply #57, on March 25th, 2017, 06:31 PM »
Sync with barter doesnt work / dont do anything. no button to see anywhere to add different games my a game list. pretty useless

Forum Conventions

  • Newbie
  • Posts: 37
  • Trades: 0

tservo2049

  • Newbie
  • Posts: 6
  • Trades: 1
Re: What's up at Lestrade's?
« Reply #59, on March 25th, 2017, 10:36 PM »Last edited on March 25th, 2017, 10:42 PM
I just got around to joining here, I also am not seeing anything happen when I hit the Import button, am I SOL for syncing with Barter?

I guess I can add tradables manually, but it doesn't look like there is any way to add what site they are on (Humble, etc.)., is that information only populated when users were syncing from Barter?

If I'm not able to sync from Barter, will my wishlist and library eventually sync from Steam itself?