[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: What's up at Lestrade's?
« Reply #435, on July 11th, 2017, 10:35 PM »
Quote from Lestrade 尚 on July 11th, 2017, 10:08 PM
This information isn't new, it's already shown in list pages, it's just new on game pages.
Erratum: this (for lists and game pages) is for wishlists only-- tradables never kept track of that information IIRC (since there's no Steam list for that, it's just a LT or BVG origin, and I didn't bother with an internal flag.)
Re: What's up at Lestrade's?
« Reply #436, on July 14th, 2017, 10:47 PM »
FIX: Offer pages were a bit screwed up on mobile devices due to a recent refactoring of the HTML to cater to non-existent banners (which, by the way, still show a broken icon on my mobile browser... Grmpf.)
I also reduced the banner width a little more, for tests. Will probably reset to a bigger size later if I can find a good balance.
Re: What's up at Lestrade's?
« Reply #437, on July 15th, 2017, 12:02 AM »
NEW: Offer pages (and bundle pages, too) should now be more compact in mobile mode. This is a bit busier, but easier to navigate IMHO. This was achieved through turning the banner into a left-floated div, so that any text that overflows it will be shown below the banner, rather than on the same 'column' as the previous text. Note that because HTML needed to be refactored for this, the feature will not work properly on narrow windows on a desktop computer. Sorry about that... But any windows below 600px of height are... things of the past..?
Re: What's up at Lestrade's?
« Reply #438, on July 16th, 2017, 01:18 AM »
Hmm, I'm still getting ratio errors on some games on a daily basis. No biggie really, since ratios are fixed soon after they're broken, but I really don't know where I added an entry point for this recount bug.

NEW: checkboxes are redesigned as flat boxes with animated checks. Hope you'll like them.
A few notes:
- This was done to enhance experience in Night mode, because a browser's default checkbox style really looks ugly on black backgrounds. I decided to use it in Day mode as well, because it looks nice.
- I need to finish Disabled mode.
- I probably should do radio buttons as well...!
- This only works in Webkit[1] derivatives for now-- exploiting a probably intentional bug in their HTML parser. Firefox and IE won't like it. I don't give a damn about IE (even its latest versions, seriously guys, don't use that crap!), but Firefox warrants my attention. I'm doing what I can to implement a similar looking effect on it, but they're not helping-- similar to Webkit scrollbars being stylable... Yeah, Firefox doesn't want that. Makes me wonder why it insists on giving you colored smileys without your approval (i.e. changing them to monochrome smileys requires using a trick), but not colored UI elements....
 1. Chrome, Chromium, Safari, Opera...

Akylen

  • Full Member
  • Posts: 218
  • Trades: 61

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: What's up at Lestrade's?
« Reply #440, on July 16th, 2017, 10:58 PM »
Thanks ;)
I've been spending 90% of the time trying to do the same on Firefox... It's just impossible. I use so many custom checkboxes everywhere... I feel like I won't be able to just magically replace them unlike on Chromium. Grmpf.
Still working on it though...

FIX: Barter stats (for your profile) were no longer imported properly on Barter sync, after a change in their HTML.
Re: What's up at Lestrade's?
« Reply #441, on July 18th, 2017, 12:17 AM »
FIX: Fixed games bundled in the last ~14 months or so. (I got bored after that. Spent my evening on it..)
e.g., many games were missing because ITAD classified them with faulty names (typos, wrong package names...)
I pretty much associated everything that could be associated with a game in the database.

I also found a weird bug in my search engine... I defy anyone to find the Civ 5 Complete Edition through it. It always find Civ 3 or 4, but not 5. I'll have to look into that...
Re: What's up at Lestrade's?
« Reply #442, on July 18th, 2017, 04:32 PM »
A big one, for a change!

NEW: Lestrade's will now remember your sort order individually for: wishlist, tradables, blacklist, library, and offer creation pages.

It doesn't look like it, but this new feature, while it can be summed up in a single line, took half a day to write, because I had to refactor a LOT of my internal code to allow for sorting server-side. Actually, if you're on a slow (e.g. mobile) browser, it might be faster for you to select the new sorting order, then immediately refresh the page, rather than wait for the sorting to be done in JS, lol.
Also, Library now explicitly allows sorting by Playtime (this is still the default, but now you can switch back to it).
Oh, and items won't be sorted exactly the same way whether done server-side or client-side. For instance, games imported at the exact same second won't be shown in the exact same order on blacklist and library pages depending on what method you sort with. It doesn't really matter now does it..?
Another example: server-side, a name in kanji/hanzi/etc. is moved at the end of the list if you sort alphabetically, while client-side, it's moved to the beginning. Also, I'm currently sorting by 'original' name, i.e. store name as found by Barter back when it was broken... Until I'm done with the scraper rewrite, you may (rarely) see some discrepancies in the A-Z order.

There you go... Enough with the technicalities. If you find any bugs, feel free to report it. I've tested many different situations, should work. If it doesn't, it's still fixable so just report it.
Re: What's up at Lestrade's?
« Reply #443, on July 18th, 2017, 05:41 PM »
NEW: The shiny new checkbox is now available in Firefox and IE9+.

Note: this is a big hack, so it's very likely you'll see it break in some areas. I haven't tested everywhere, so... Please remember to report bugs you find, however little they are! I'm interested in fixing even stuff where one pixel is off!

NEW: Radio buttons (e.g. single-choice offers) now sport the same look as checkboxes. Available in Chromium, Firefox and IE9+.

These stupid hacks took me a week of work... Guys you'd better +Like that post even if you don't use Firefox or IE! ESPECIALLY if you don't use them, because I made sure not to add any extra HTML for Chromium-based browsers! :P

/u/humpaaa

  • Full Member
  • ▶ ¦ Yep
  • Posts: 190
  • Trades: 10

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,396
  • Trades: 223
Re: What's up at Lestrade's?
« Reply #445, on July 18th, 2017, 08:11 PM »
Well that's one of the last few things I hadn't done yet that was on bvg ;) although bvg doesn't remember per list but site wide, and it doesn't do real time refreshing.
My main motivation was that I always send offers based on ratio, so I always had to change the sort order...
Re: What's up at Lestrade's?
« Reply #446, on July 18th, 2017, 08:52 PM »
NEW: Lestrade's is now in white-on-black by default for guests. ;)
Since guests can't change to day mode (yet?), I had to make sure the site was as usable as possible in night mode. I consider it is now, so I'm trying this.
Note that once you sign into the site, you'll still be in day mode by default. If as a guest you liked night mode, I'm sure you'll find the prominent button in the header. ;)

Please vote in the relevant poll if you like or dislike this move!
Re: What's up at Lestrade's?
« Reply #447, on July 19th, 2017, 12:43 AM »
FIX: Crash when using "Add to tradables" on a bundle page where the bundle store isn't currently listed in an official capacity in the LT source code. (e.g. Otaku Bundle.)
Re: What's up at Lestrade's?
« Reply #448, on July 19th, 2017, 12:11 PM »
FIX: Firefox + tradable list = unclickable checkboxes, because of some weird (and still unexplainable) event propagation. I'm considering simplifying my JS and CSS for a safer solution, but it will however make the checkboxes non-accessible, i.e. they won't be reachable by keyboard (e.g. for disabled users); then again the pop-up that shows up when you click those checkboxes has never been accessible, and I never received a complaint about that. Maybe I shouldn't bother... I don't know.

NEW: Profile pages will now indicate whether a user is very dynamic or passive. It simply counts the number of sent & received offers, and if one number is at least 4 times higher than the other (I chose a random ratio really), then one can be considered dynamic/proactive (sends way more offers than receives them), or passive (waits for offers to arrive, basically.)
I thought this could be important in the sense that a proactive user will be more likely to be involved in how the site works, too.
Re: What's up at Lestrade's?
« Reply #449, on July 19th, 2017, 10:26 PM »
FIX: Okay, another complicated bit... Steam auto-sync was fixed last week, but I also inadvertently added another bug in that I used incorrect math for time testing, and lists were only auto-synced approximately on a weekly basis, rather than daily... Oops. So, I fixed that. Should work fine now.

NEW: Also used the opportunity to update the "Sync with Steam" button to show on hover the last synchronization date ("Last sync: 3 minutes ago" would mean it's up to date, for instance.) Also, the button will now auto-sync both your Steam Wishlist & Library, meaning you won't have to click the button on both your Wishlist & Library pages. This'll save you some time, as I strongly suspect anyone wanting to import their library would also like to use the opportunity to update their wishlist... (e.g. if they redeemed a new game they'd previously wishlisted.)
Items won't be automatically removed from your wishlist once your library is updated, though. This will have to wait until either you go to your Wishlist tab and select to remove or keep the items, *or* the cron job (scheduled task) for wishlist cleanup fires up (I don't remember how long it is, but it's pretty short, like a few minutes.)

Hope you like the changes.