Can only see tradables that aren't in my library

Zomby

  • Newbie
  • Posts: 10
  • Trades: 4
Can only see tradables that aren't in my library
«  »
As of today, I can only see tradables that are in my library.

While I'm sure it would be a very nice OPTIONAL feature when looking at someone else's tradables, it's quite useless when looking at mine and actually prevents me from managing my tradables properly. (Now I have to find every single game manually again to delete them after doing a large trade, while I could finally delete them all from the tradable list before this change.)

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,212
  • Trades: 195
Re: Can only see tradables that aren't in my library
« Reply #1,  »
I'll look into this. Obviously it's unwanted. ;)
Posted: June 3rd, 2017, 07:59 PM

What does the page say exactly..? can you post a screenshot? (including URL)
My code seems to be okay but I'm tired so maybe I'm missing it.

PS: the problem has to be code-related because that's one of the things I worked on today-- adding a 'no library' filter for non-premium users. (The feature had already been available to the few premium testers on the site for weeks now.)

Zomby

  • Newbie
  • Posts: 10
  • Trades: 4

[Lestrades.com] Nao 尚

  • I'm Share-Locked
  • Administrator
  • Posts: 1,212
  • Trades: 195
Re: Can only see tradables that aren't in my library
« Reply #4,  »
Should be fixed now.
That was a nasty bug-- ironically, one bug I already met a few weeks ago.
$_GET['lim'] = ($_GET['lim'] ?? 0);
That's all there was to it... "If lim isn't set, force it to 0".
Then in a later line, I test $_GET['lim'] == 'nolibrary'.
That's all there was to it. A non-set 'lim' is now 0, and 0 == 'nolibrary', because PHP sucks sometimes.
Just adding an extra '=' to the '==' was enough to fix it.
I didn't catch the bug originally because I'm a permanent premium user, so I always get to skip that test. :^^;: