Lestrade's

Lestrade's Lounge => The Fatal Problem => Topic started by: Forum Conventions on February 13th, 2017, 11:20 AM

Title: Issue(s)
Post by: Forum Conventions on February 13th, 2017, 11:20 AM
Figured I'd make a new thread instead of clogging up the existing one.


I'll add to this as I find more.
Title: Re: Issue(s)
Post by: CMA on February 13th, 2017, 11:32 AM
I have found little visual bug with % value at game site for ex. for The Forest

Tradable 29 (70.73%)
Wished 380 (926.83%)
% probably compare wrong total number ;p
Title: Re: Issue(s)
Post by: Forum Conventions on February 13th, 2017, 11:37 AM
Quote from CMA on February 13th, 2017, 11:32 AM
I have found little visual bug with % value at game site for ex. for The Forest

Tradable 29 (70.73%)
Wished 380 (926.83%)
% probably compare wrong total number ;p
I'm sure it's probably comparing to the number of users currently registered on the Lestrade's, not the number of people registered at Barter.
Title: Re: Issue(s)
Post by: CMA on February 13th, 2017, 11:47 AM
Quote from Alex on February 13th, 2017, 11:20 AM
Figured I'd make a new thread instead of clogging up the existing one.

  • Changing forum profile info nukes avatars
  • No option to change the time zone

I'll add to this as I find more.
Here you can change timezone: http://lestrades.com/@antigravities/?area=options

& you have also right about the 1st one, Dude, Where's My Car? ^^
Quote from Alex on February 13th, 2017, 11:37 AM
I'm sure it's probably comparing to the number of users currently registered on the Lestrade's, not the number of people registered at Barter.
If so this value never gonna be right.. should compare to number of registered users from barter who wishlist or have tradable this game
Title: Re: Issue(s)
Post by: Milouze on February 13th, 2017, 01:24 PM
Quote from Alex on February 13th, 2017, 11:20 AM
  • Changing forum profile info nukes avatars
  • No option to change the time zone
Both work fine for me here. I posted an issue about the custom avatar though, Nao responded here:
http://steamcommunity.com/groups/bartervg/discussions/0/133256959377120682/?tscn=1486944945#c133256959377336784

I am not getting notifications from here yet so I suggest we stick to Barter.vh steam group for issues reporting guys. Otherwise we're blind on one side or the other :)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on February 13th, 2017, 06:51 PM
- Avatars: this is a current limitation. I should probably just remove those options manually (from the source code). You should be able to reset your avatar by logging off.
- Timezone: go to your profile > Modify Profile > Look and Layout.
- Percentages: another detail I forgot to change during the move. And yes, as Alex pointed out, it was calculated against the real number of members here, rather than the number of members on Barter. ;)

I should also look into notifications. For some reasons I'm not getting any either. I didn't enable them in Profile > Notifications > Emails and Messages (or something), because I only want website notifications (top left of the page has a number, is currently 0...) but it's not working. Probably a setting I didn't correctly initialize.
We have time, we have time! At least the main attraction of this website is doing its job fine. :P
Title: Re: Issue(s)
Post by: CMA on February 13th, 2017, 08:32 PM
Yee I have found my car ^^ (re-login works)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on February 14th, 2017, 01:21 PM
CURRENT BUG: the SSL certificate was invalidated by making a minor change in some settings. Unfortunately this is a bug that's not on my side, and I can't fix it. And because of timezones, Alex isn't around to do it, and won't be for a few more hours.

Please bear with me, and just accept the certificate when the popup comes up. Or just don't use the website for a few hours if you can't trust it.
Title: Re: Issue(s)
Post by: Caviezel on February 16th, 2017, 08:35 AM
Where is the logout button?

When do tradables and wishlist synchronizes?
Title: Re: Issue(s)
Post by: CMA on February 16th, 2017, 11:15 AM
Quote from Donpeste on February 16th, 2017, 08:35 AM
Where is the logout button?

When do tradables and wishlist synchronizes?
Profile -> Logout

Sync twice a day:
~1:30am, 1:30pm CET
(on request not available at the moment)
Title: Re: Issue(s)
Post by: Akylen on February 16th, 2017, 06:44 PM
The skin selector doesn't appear to be working. Whenever I select 'Use this skin' on any of the skins it refreshes the page, seems like it switched but current theme always shows Forum Default.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on February 16th, 2017, 07:05 PM
Skin selector is disabled...
Title: Re: Issue(s)
Post by: Nimmy on February 26th, 2017, 08:08 AM
Wishlist does not seem to synchronise. I've done two trades yesterday (both of them around 4pm CET), and the two games I obtained still appear in my wishlist
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on February 26th, 2017, 10:16 AM
Happens from time to time. I checked and yes the import failed. It will automatically be redone in a few hours. Alex said she'd rather not do more than two scrapes a day, and as I said importing blacklists increases scraping time by 30% so it also increases php crash chances by 30%.

I'll try to implement the queue system today. That way you'll have a button to synchronize your lists immediately. Sorry about that.
Title: Re: Issue(s)
Post by: Akylen on February 27th, 2017, 11:31 PM
When using the matching feature it doesn't seem to be validating the ignore user list and it matches against users I already had ignored. Hopefully the ignore list can be implemented here or use from Barter.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on February 28th, 2017, 08:09 PM
I already said it can't.
Barter doesn't disclose ignored members publicly. It only shows them members YOU ignore for instance, and not members who ignore you. Why is ridiculous because it still allows you to filter games against those who ignore you. And it does indicate the user is ignoring you, at that point. It's a half arsed implementation at best.

I could implement ignoring users manually here, but you still would see matches for people who ignore you.
Title: Re: Issue(s)
Post by: Akylen on February 28th, 2017, 11:45 PM
Quote from Nao 尚 on February 28th, 2017, 08:09 PM
I already said it can't.
Barter doesn't disclose ignored members publicly. It only shows them members YOU ignore for instance, and not members who ignore you. Why is ridiculous because it still allows you to filter games against those who ignore you. And it does indicate the user is ignoring you, at that point. It's a half arsed implementation at best.

I could implement ignoring users manually here, but you still would see matches for people who ignore you.
Ahh right! That makes sense.

It would be good to have that feature here then. I like how we can say: "skip this user in matches for X amount of time". It is never permanent. If that is made into a list, even better. We get a clear picture.
Title: Re: Issue(s)
Post by: jeremy.jj on March 1st, 2017, 10:09 PM
I can no longer see the game search bar in the top right.  Was it removed?  Now there is a notifications bar that seems to occlude the old search area.

edit: search bar is back.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 4th, 2017, 11:08 AM
Yes Jeremy, it was a bug. I largely rewrote the header to be fixed (like in Barter), and I didn't test it enough.
After your post I kept modifying the code, so it may have broken at times, too.
I'm not 100% done, but I'm getting very close to what I was looking for.
Quote from Akylen on February 28th, 2017, 11:45 PM
It would be good to have that feature here then.
Let's just say that features that arbitrarily diminish the number of possible matches aren't going to be implemented unless there's a real userbase commitment to it.
I can't even enumerate all the people on Barter who added me to their ignore list without warning because I *argumented* how I valued a game in a trade. That isn't to say I said "My game is better you suck!", no, I said things like "It was bundled x times and lowest Steam price was recently y, so I think a 2:1 is more balanced than your 1:1". And voilà, I get ignored. I'd rather have a tool that allows people to counter that. For instance, notify people that they were put on an ignore list. They can then argue in public that the ignorer is an incompetent trader. Or possibly a better solution: keep an online track of everyone's ignore lists. If someone ignores many people who aren't ignored by many others, they might be flagged as 'quick shots' and as such demoted from trader reputation rankings.
Hmm yeah I like that idea.

In fact it's close in spirit to my plans to give everyone two rep systems: the completed offer rep (like Barter), and a trader reputation rep (possibly anonymous), which would allow one to rate someone's likeability (basically, a 'Recommended' rating.)
Site contributors (admin, host, moderators?) would probably be free from that rating, though, because they might be biased toward their site role rather than trader role.
Title: Re: Issue(s)
Post by: Akylen on March 9th, 2017, 12:22 PM
Quote from Lestrade on March 4th, 2017, 11:08 AM
Yes Jeremy, it was a bug. I largely rewrote the header to be fixed (like in Barter), and I didn't test it enough.
After your post I kept modifying the code, so it may have broken at times, too.
I'm not 100% done, but I'm getting very close to what I was looking for.
Quote from Akylen on February 28th, 2017, 11:45 PM
It would be good to have that feature here then.
Let's just say that features that arbitrarily diminish the number of possible matches aren't going to be implemented unless there's a real userbase commitment to it.
I can't even enumerate all the people on Barter who added me to their ignore list without warning because I *argumented* how I valued a game in a trade. That isn't to say I said "My game is better you suck!", no, I said things like "It was bundled x times and lowest Steam price was recently y, so I think a 2:1 is more balanced than your 1:1". And voilà, I get ignored. I'd rather have a tool that allows people to counter that. For instance, notify people that they were put on an ignore list. They can then argue in public that the ignorer is an incompetent trader. Or possibly a better solution: keep an online track of everyone's ignore lists. If someone ignores many people who aren't ignored by many others, they might be flagged as 'quick shots' and as such demoted from trader reputation rankings.
Hmm yeah I like that idea.

In fact it's close in spirit to my plans to give everyone two rep systems: the completed offer rep (like Barter), and a trader reputation rep (possibly anonymous), which would allow one to rate someone's likeability (basically, a 'Recommended' rating.)
Site contributors (admin, host, moderators?) would probably be free from that rating, though, because they might be biased toward their site role rather than trader role.
It is in the trader's right to ignore anyone she wants. After all the trader owns the game and she will have specific criteria for their trades. I don't mind being ignored, I know it is not personally but rather a criteria. There are plenty of other traders with similar criteria to mine. Think of ignore as a polite manner to say: "Sorry but we clearly can't reach to an agreement. It is better if we don't trade for a while".
Criteria's could change however, that is why I think ignoring for a certain period is very powerful, as opposed to ignoring forever.

With that said, publicising ignore lists or making trader's argue about ignores will be a complete disaster and will ruin the experience for passionate traders. Effectively that would make the trading system a parody, everyone needs to like everyone and have the same criteria! World doesn't work like that.

I agree with notifying those who get ignored. Make the ignore with a mandatory message, so that the trader being ignored knows the reason why.

I think there is a place for a public trader blacklist. For instance, rude, fake, mal intentioned, problematic traders would have a place in there. It is in the interest of the community to expel people with these characteristics! Not sure how that fits with steamtrades feedback, but it could be something interesting.

Could we start with a simple ranking mechanism? Similar to how forums or ebay works. The more feedback you have, the better your star is. To calculate the ranking could be something like
Code: [Select]
completed trades / completed trades + failed trades
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 9th, 2017, 12:27 PM
You know, you don't have to use bold characters, it's likened to screaming. I hear you alright. I'm willing to listen since no one seems to have an interest in discussing anything on these forums... :-/ (At some point I even wondered if I hadn't broken some permissions.)
Title: Re: Issue(s)
Post by: Akylen on March 9th, 2017, 01:49 PM
Quote from Lestrade on March 9th, 2017, 12:27 PM
You know, you don't have to use bold characters, it's likened to screaming. I hear you alright. I'm willing to listen since no one seems to have an interest in discussing anything on these forums... :-/ (At some point I even wondered if I hadn't broken some permissions.)
That wasn't the intention at all. I used bold just to emphasise a point.
Hopefully we will have more viewpoints on this.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 9th, 2017, 03:34 PM
Ignore lists as implemented on LT (not active for now) last forever, and it would complicate the ui to make it possible to ignore for a limited time. Barter has a skip feature that does the same job, but people don't use it-- possibly because you can't view your current skips.
It would be technically feasible to ignore a combination of one game + one user, I.e. this user can no longer offer me anything for that game, or I don't want to see that game in their tradables because they're asking too much for it and I'd be wasting my time. But it's also complex to implement -- should I add an ignore button next to the game in the offer? Would need to educate users as to what it does, too.
It's just so annoying. Barter has a good system but its ignore lists really encourage shrinking your possibilities.
Title: Re: Issue(s)
Post by: Akylen on March 10th, 2017, 01:52 AM
Quote from Lestrade on March 9th, 2017, 03:34 PM
Ignore lists as implemented on LT (not active for now) last forever, and it would complicate the ui to make it possible to ignore for a limited time. Barter has a skip feature that does the same job, but people don't use it-- possibly because you can't view your current skips.
It would be technically feasible to ignore a combination of one game + one user, I.e. this user can no longer offer me anything for that game, or I don't want to see that game in their tradables because they're asking too much for it and I'd be wasting my time. But it's also complex to implement -- should I add an ignore button next to the game in the offer? Would need to educate users as to what it does, too.
It's just so annoying. Barter has a good system but its ignore lists really encourage shrinking your possibilities.
Could be one of the possibilites. Some traders insist on the same games and it just doesn't go anywhere.

If it is complicated to ignore for a limited time, keep the ignore forever with liabilities. What do you think showing a popup/sending an email from time to time for the trader to review his ignore list? Ideally showing the users ignored for the longest first on a separate page!
Maybe also show the ignore list on the right side on the trade list. Not sure how intrusive it could be, so perhaps make it optional.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 16th, 2017, 03:07 PM
Just a quick note: I've been having problems with matches since last night. I made a very minor change to the query to prevent results that might be too complex for the server, and I noticed I no longer get complete matches. (I still get thousands, but for some reason after a while I get a page crash.)
I'll try to restart with yesterday's copy of the site, just to test and figure out what's wrong. I'm not even sure you guys are seeing the same problems as I do. Just wanted to let it be known that if you're having problems, the fact that I'm not fixing them is because I'm busy completing the offer system. ;)

:edit: Apparently it's only started this morning so this would be unrelated. Also, the page loads ALL elements, it's just that for some reason it doesn't show them all at once... It shows about 95%, then stalls for 30 seconds or so, then it shows the rest. So weird. I'll just have a quick look, because I'm too curious not to try to fix that.

:edit: Okay, found the problem... Wasn't with my match code actually. Normally it only affected me, as an administrator. So, I fixed it for myself, shouldn't change anything for you.
Title: Re: Issue(s)
Post by: Quantum on March 20th, 2017, 10:08 PM
Is sorting by Ratio (rarest first) broken on the Tradeables page? All the other filters seem to work fine, but this one does nothing.
Title: Re: Issue(s)
Post by: Nedkelly on March 20th, 2017, 10:16 PM
I have the same problem, also think ratio sorting is a problem on 'wishlist' site :hmm:

Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 21st, 2017, 12:14 AM
It's working for me, did you happen to post during the few minutes where I was rewriting the ratio code? :P
Title: Re: Issue(s)
Post by: Quantum on March 21st, 2017, 12:24 AM
Quote from Lestrade on March 21st, 2017, 12:14 AM
It's working for me, did you happen to post during the few minutes where I was rewriting the ratio code? :P
Did a CTRL-F5 and tried again. No difference (all other filters cause the list to change, that one doesn't). Firefox.

I also tried on Chrome and on Chrome the list does change, but the filtering shown is absolutely not most rare at the top.
Title: Re: Issue(s)
Post by: Pika! Pika! on March 21st, 2017, 02:10 AM
Personally I am not a fan of ignore forever lists. As a matter of fact I prefer to not ignore anyone as it simply maximizes the chances of making a deal. Most of those ignores seem to originate from miscommunication resulting from a lack of understanding each other's valuation method. Those judgments are made in an instant and can last forever. It might have had nothing to do with the individual at all....for all you know the other trader had a bad day at work or his/her dog died and that frustration then can get expressed in a trade. If I do not like the offers someone one might give me, I prefer to talk about it and discuss why I am not interested, so that it is less likely to happen again.

I might have expressed the situation with permanent ignores not correctly above. The issue is that it tends to happen too swiftly and without notice and one can thus cannot remedy it most of the time. So what I would therefore like to propose is a sort of 'cards' system whereby you can warn another trader that you really do not like certain offers. So what I propose is that as a trader you can give another trader a 'green card', then a 'yellow card' (with or without a temporary ignore of a day, 3 days, a week or a month) and then a 'red card' with the 'red card' being a permanent ignore. That should provide enough flexibility to work things out. If a trader then notices they have received a green or yellow card, they can try to talk it out with that other trader or at least be aware that there is something they preferably can do differently instead of receiving those one hit knockouts that seem to come out of nowhere. What would work even better is if the trader who gives the other trader a card has to specify what they do not like such as behaviour, steam prices comparison, H/W ratio comparison, wishlisted total comparison, price paid comparison, G2A price comparison, multiple valuation methods, gameplay difference or the perception that the other trader seeks to profit systematically from each trade. That way the trader who has been given the warning card can work on the issue and improve not only the future trades they make, but also the community.
Title: Re: Issue(s)
Post by: Forum Conventions on March 21st, 2017, 02:34 AM
But then you get people who will abuse the "3 strike" system (*cough*"high value game and another"*cough*). Sure, that can be an option, but it shouldn't be the only one.

I still don't get the "butthurt over being ignored" thing. So what if you get blocked? You should see it as another trader having a different idea of value than you, not a personal attack, unless you were being an ass unprovoked in the first place (which I will admit to doing more than once) - then you deserve it.
Title: Re: Issue(s)
Post by: Pika! Pika! on March 21st, 2017, 02:53 AM
Quote from Alex on March 21st, 2017, 02:34 AM
But then you get people who will abuse the "3 strike" system (*cough*"high value game and another"*cough*). Sure, that can be an option, but it shouldn't be the only one.

I still don't get the "butthurt over being ignored" thing. So what if you get blocked? You should see it as another trader having a different idea of value than you, not a personal attack. Unless you were being an ass in the first place (which I will admit to doing more than once), then you deserve it.
Hi Alex,

I certainly would not take it personally if I get ignored, but I think the immediacy of ignores at Barter.vg lowers trading success and I do not see that as necessary if that can be remedied. Some traders might still insist on immediately ignoring someone and that cannot be prevented and neither should we insist on that if a trader truly feels strongly about such a specific action. If traders had more tools to express their perspective, they probably would be less likely to resort to ignores and increase their trade success instead.

I might have a different perspective on the use of an ignore. Barter in my opinion never had a proper way in which traders could indicate which valuation method they used, so then numerous traders resorted to ignores to solve that issue. I thus think it would be better to ensure that traders have more room to express their valuation methods by default, so that an ignore can truly be used as a last resort when working with another trader is perceived as unworkable. In that sense if would be nice if one could even search for matches by means of specific valuation methods (and thus filter out the rest when so desired).

Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 21st, 2017, 08:02 AM
Re: Firefox, the only difference I noticed is that the dropdown was slightly broken with it (overflow issue). I fixed that. The sorting, however, works the same as Chrome for me.

Re: sorting, Quantum-- I even tried on your particular wishlist, and it's sorting the games just fine (starts either with a list of 0-tradable games, or with Titan Souls, your most 'common' wishlisted game-- ah, how the trading world has changed :lol:)
I really don't know what's up. Did you reload your page? Gosh I'm surrounded by techies, not computer noobs :P

@theemu (Jennifer?!?!), yes I know you like working through the magic of how websites work :D, here it's a very simple implementation that works fine on modern computers (it's quite slow on my old phone, but still way faster than reloading the page like Barter forced us to :P), but I *am* getting proper ratios...
Hmm wait...

Okay I got it, I went overboard with that because ratios are calculated live and I was afraid they'd make the site load slower. It isn't really the case so I'll be enabling them for everyone in lists. Later on I'll store these numbers instead of doing them live. I just need to update them as games are added or removed, after all.

Re: ignore lists, really glad to see I'm getting traction with the idea of offering people the ability to tell what they trade for. ;)
Title: Re: Issue(s)
Post by: Caviezel on March 21st, 2017, 08:40 AM
It would be great if clicking on the profile picture (right column) would take you to your profile.

Also if the lestrades logo on the upper right corner would take you to the main page. Right now, the only way to go to the main page is go up the screen, hover on "Home" and click on "lestrades". It's easier to click on the browser bookmark.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 21st, 2017, 12:17 PM
Profile picture: why not just click on the Profile menu link?

Home: you don't have to click on Lestrade's, just click on Home. I'm planning to have the logo clickable but it's a background image, not an IMG, so I need to make the entire div clickable. I'm more concerned that mobile doesn't really have an easy way to reach the homepage.
Posted: March 21st, 2017, 09:16 AM

Home link implemented on the LT logo. Of course it's just a hack, so you can't open it in a new tab. You'll have to use the menu for that.
Title: Re: Issue(s)
Post by: Nedkelly on March 21st, 2017, 06:55 PM
Quote from Nao 尚 on March 21st, 2017, 12:14 AM
It's working for me, did you happen to post during the few minutes where I was rewriting the ratio code? :P
Might be, it is working for me now :cool:
Quote from Nao 尚 on March 21st, 2017, 08:02 AM
Re: ignore lists, really glad to see I'm getting traction with the idea of offering people the ability to tell what they trade for. ;)
Like this, also don't know if it has been mentioned, I do not like Barters option for turning off comments in a trade, making it hard to understand each other value/view point, if you cannot ask questions about the trade :)
Title: Re: Issue(s)
Post by: Quantum on March 21st, 2017, 11:32 PM
Quote from Nao 尚 on March 21st, 2017, 08:02 AM
Re: Firefox, the only difference I noticed is that the dropdown was slightly broken with it (overflow issue). I fixed that. The sorting, however, works the same as Chrome for me.

Re: sorting, Quantum-- I even tried on your particular wishlist, and it's sorting the games just fine (starts either with a list of 0-tradable games, or with Titan Souls, your most 'common' wishlisted game-- ah, how the trading world has changed :lol:)
I really don't know what's up. Did you reload your page? Gosh I'm surrounded by techies, not computer noobs :P
Thanks for the fix :).
Title: Re: Issue(s)
Post by: Quantum on March 21st, 2017, 11:43 PM
Quote from Pika! Pika! on March 21st, 2017, 02:10 AM
I might have expressed the situation with permanent ignores not correctly above. The issue is that it tends to happen too swiftly and without notice and one can thus cannot remedy it most of the time. So what I would therefore like to propose is a sort of 'cards' system whereby you can warn another trader that you really do not like certain offers. So what I propose is that as a trader you can give another trader a 'green card', then a 'yellow card' (with or without a temporary ignore of a day, 3 days, a week or a month) and then a 'red card' with the 'red card' being a permanent ignore. That should provide enough flexibility to work things out. If a trader then notices they have received a green or yellow card, they can try to talk it out with that other trader or at least be aware that there is something they preferably can do differently instead of receiving those one hit knockouts that seem to come out of nowhere. What would work even better is if the trader who gives the other trader a card has to specify what they do not like such as behaviour, steam prices comparison, H/W ratio comparison, wishlisted total comparison, price paid comparison, G2A price comparison, multiple valuation methods, gameplay difference or the perception that the other trader seeks to profit systematically from each trade. That way the trader who has been given the warning card can work on the issue and improve not only the future trades they make, but also the community.
I mostly agree with Akylen on this. If you don't want to trade with a certain person, that's your choice to make. I don't see the need for over complicating it (with cards i.e.) and basically forcing people to communicate with people they don't really want to trade with anyway. If someone ignores a lot of people he / she will reduce his own potential matches mostly. That's a very basic incentive to not over use it. Also, I'd be curious how many people actually have more then 10 people ignored on Barter right now (Nao? ;-)). I'm betting it's not that relevant an amount compared to the total user base.

An option to optionally show ignored users in your matches could be interesting though; that way there'd be additional incentive to once in a while to give someone another chance.
Title: Re: Issue(s)
Post by: devotee on March 22nd, 2017, 01:52 AM
Quote from Nao 尚 on March 21st, 2017, 12:17 PM
Profile picture: why not just click on the Profile menu link?
I noticed that but since it wasn't a priority I was saving it for later. I think it's more intuitive to click on the user's picture to go to the profile instead of going up and looking for the profile link.

Besides that:
- User picture -> Profile = one click
- Profile  -> Dropdown -> Summary = more work (plus one extra click when you click on "Profile" and you realize that it doesn't go anywhere and that you have to click on "Summary", happened to me a couple of times)
- It's how it works in the forums (left column avatars link to the profiles)
Title: Re: Issue(s)
Post by: Gelweo on March 24th, 2017, 12:30 PM
A small bug : Desolate Wastes: Vendor Chronicles title is replaced by  Deus Ex: Human Revolution - The Missing Link
Title: Re: Issue(s)
Post by: joaoarena on March 24th, 2017, 12:34 PM
Why some games have the feature "✽ Was present in these bundles..." and some games have not?

I use this feature a lot to find out where to search on the right bundle for the tradables I own.
Title: Re: Issue(s)
Post by: devotee on March 24th, 2017, 07:03 PM
Quote from joaoarena on March 24th, 2017, 12:34 PM
Why some games have the feature "✽ Was present in these bundles..." and some games have not?
I think it has to do with LT not having scrapped all past bundles, and not scrapping/adding new ones. It's on the to-do list, but I guess it's well behind improving the offer system and adding editing to the tradable/wishlist/blacklist/library...
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 24th, 2017, 10:34 PM
Yes, I can manually launch an import of all recent bundles from ITAD, I just need to save the HTML for the latest bundles to get their IDs, then run my little scraper. It's not very practical, for obvious reasons. I should automate this, but as I said before, I'm also planning to add the ability to edit/add bundles manually in case ITAD is taking too long to add crucial bundles like Humble's. So it's not an easy decision to make.
Oh, maybe I could just compare the URL to the existing bundles, and if I scrape and ITAD bundle with the same URL (like at humblebundle.com), then I could just ignore it. That's a good idea. Thanks, Nao, good suggestion. Now where's my cigar?
Title: Re: Issue(s)
Post by: Quantum on March 24th, 2017, 10:46 PM
With thanks to eifelkenny:
iO (https://lestrades.com/game/5263/) can't be searched for (probably due to the game name being only 2 characters).
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 25th, 2017, 12:20 AM
It's more the simple fact that there are so many games with 'io' in their name... :^^;:
I've fixed it to sort by length so that it returns 'Io' in first position, but then the search was about 20 to 40 times slower than before. It was still fast, but unacceptable to me, so I reverted it.
As a reminder: for games that are on Steam, just go to their store page, then replace 'steampowered' with 'lestrades' in the URL. You'll be redirected to the corresponding LT page. Not ideal, but works every single time.
Title: Re: Issue(s)
Post by: beareryet on March 25th, 2017, 03:04 AM
Hero of the Kingdom II doesn't show up in search.
ED: and sometimes it shows up twice... ??? I don't know how to make it happen again.

And not really a issue, but a detail. I noticed that on offers the name of the game is linked to its lestrades page. Since that little arrow beside it is redundant, as it links to the same page, couldn't it be redirected to steam instead?
Title: Re: Issue(s)
Post by: beareryet on March 25th, 2017, 03:16 AM
Quote from ☺☺☺ on March 25th, 2017, 03:14 AM
Try this:
First search for "hero of the kin"
then backspace 1 character so it becomes "hero of the ki", and it should show up.
Weirdly, it works, thanks!
Title: Re: Issue(s)
Post by: devotee on March 25th, 2017, 03:41 AM
I've also noticed that the search box acts funny sometimes, here's proof (and bug report)!

(http://i.imgur.com/A9yUWAl.gif)

I discovered this while trying to search for NeverEnd(http://store.steampowered.com/app/575840/), which doesn't show up in the results :-/
Quote from Nao 尚 on March 24th, 2017, 10:34 PM
Yes, I can manually launch an import of all recent bundles from ITAD, I just need to save the HTML for the latest bundles to get their IDs, then run my little scraper.
Oh, that would be great for the past (recent :P) bundles. No need for a bundle edit system right now. A simple index page for all scrapped bundles would be nice, too (sorted, more recent first). It would be useful to quickly add games to the tradable list (go to bundle page, click on a recent bundle, open each game on a different tab -via ctrl or middle mouse click-, then on each separate game page/tab click on the "Add to Tradables" button if needed). I really miss how easily it was to add games thanks to Rowtan's work with bundles on Barter (go to bundle page, select games -or select all-, add to tradable).

If it's easy/quick to do, it would be also nice to state in a bundle page which games are owned/wishlisted/blacklisted/tradable ("à la barter"). Maybe even a bit better, coloring the background for each row (green owned, blue wishlisted?) besides adding the corresponding icons somewhere (after the title or below it).
Title: Re: Issue(s)
Post by: chaosfrost on March 25th, 2017, 09:01 AM
Quote from devotee on March 25th, 2017, 03:41 AM
I discovered this while trying to search for NeverEnd(http://store.steampowered.com/app/575840/), which doesn't show up in the results :-/
Cause it is called "Neverwinter" :D
https://lestrades.com/game/30641/

There must me some tool to edit titles that weirdly imported/added/changed over time.
Title: Re: Issue(s)
Post by: impaler0815 on March 25th, 2017, 01:23 PM
D: The Game also doesn't show up in search:

http://store.steampowered.com/app/510590/
Title: Re: Issue(s)
Post by: impaler0815 on March 25th, 2017, 02:26 PM
Quote from ☺☺☺ on March 25th, 2017, 02:20 PM
Quote from impaler0815 on March 25th, 2017, 01:23 PM
D: The Game also doesn't show up in search:
http://store.steampowered.com/app/510590/
You can find any Steam game at LT easily if you know the game's Steam Store URL. Just replace "store.steampowered" to "lestrades": http://lestrades.com/app/510590/
Thanks for the heads up!
Title: Re: Issue(s)
Post by: impaler0815 on March 25th, 2017, 03:14 PM
Just saw a few minor issues - nothing big but i'll post them anyway. ;)

A few games are listed under the wrong name at lestrades - two examples:

"Town of Night" is listed as "Tracks and Turrets":

http://store.steampowered.com/app/546990/
https://lestrades.com/app/546990/

"Shadows 2: Perfidia" is listed as "Shadows: Price For Our Sins":

http://store.steampowered.com/app/606330/
https://lestrades.com/app/606330/

And the Steam level display on lestrade's profile page is wrong - i'm level 66 but on my profile page the Steam level is 64:

http://steamcommunity.com/profiles/76561198116534142/
https://lestrades.com/@76561198116534142/
Title: Re: Issue(s)
Post by: willKane on March 25th, 2017, 04:16 PM
I can't synch wishlist and library through barter. What should I do?
Title: Re: Issue(s)
Post by: chaosfrost on March 25th, 2017, 06:40 PM
Stuck when tried to edit sent offer
https://lestrades.com/offer/460/
Got error message and now cant edit or delete this offer at all.

Edit: unstuck after some time.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 25th, 2017, 07:13 PM
About the search engine: there's nothing miraculous in it. I search for words individually, that's all there is to it. However, the auto-suggest code is from Wedge, and I rewrote it from an earlier SMF implementation. The thing to keep in mind is that in order to 'feel' faster, the more you type, the less it searches the database. It will instead search among the existing search results. When you use backspace, it'll widen its result set from a previous save. I need to fix the thing though, because it's obviously not behaving well with a relatively complex set of results. The SMF version, after all, never tried to search for anything more than member names... Way, way easier to handle.

About game names: as often said, the database is taken from Barter. It doesn't really update its names, so I'm 'stuck' with those. I'm planning to hold two names in the database in the future: one from store pages (or Barter pages right now), and one from the Steam API, which sometimes have slightly different names. No time to work on that for now, though...

@theemu, actually you just need to replace 'steampowered' with 'lestrades'. 'store.lestrades.com' (http or https) automatically redirects to the correct, https-enabled URL. I did my best to make it easy to find games within LT in a geeky way. ;)

@impaler, 'Tracks and turrets'... Is that the previous name for that game, or an ACTUAL mix-up? Would be interested in knowing...

Re: Steam levels, they're only updated if you log out and log back in (it also updates your nickname, avatar and other Steam profile information). Did you do it?

@theemu- (2), yes, I'll do that if I can't find time to implement a proper double import of game names.
Literally, I'm just lazy here, because most of the code for that is ready-- I'm just not ready to handle doing double searches. Unless I only search on the API names and pray that everyone will be happy with them...

@willKane, when you say you can't sync, did you press the Sync button and then nothing happened..? Or did you fail to find the button? Did you look for it? Did you expect an automatic import? Do you want one? (I'm not enthusiastic about doing that... ^^)

@chaosfrost, what did you with your tradables in that offer..? It's messed up. Did you remove the games from your tradables while editing the offer? Because LT seems to be unable to find some of the tradables. I didn't account for that originally, so I fixed it to silently ignore those missing entries. Now you should finish your edit. ;)
Title: Re: Issue(s)
Post by: chaosfrost on March 25th, 2017, 07:19 PM
Quote from Nao 尚 on March 25th, 2017, 07:13 PM
@chaosfrost, what did you with your tradables in that offer..? It's messed up. Did you remove the games from your tradables while editing the offer? Because LT seems to be unable to find some of the tradables. I didn't account for that originally, so I fixed it to silently ignore those missing entries. Now you should finish your edit. ;)
This is why i went to edit that offer. Traded some game on barter then delete from my wants here, then want to remove that game from offers i sent earlier. Seems like that was wrong order.
Title: Re: Issue(s)
Post by: impaler0815 on March 25th, 2017, 07:23 PM
Quote from Nao 尚 on March 25th, 2017, 07:13 PM
@impaler, 'Tracks and turrets'... Is that the previous name for that game, or an ACTUAL mix-up? Would be interested in knowing...

Re: Steam levels, they're only updated if you log out and log back in (it also updates your nickname, avatar and other Steam profile information). Did you do it?
There was a game called "Tracks and Turrets" in the Steam store but it has been removed so that's apparently a mix-up.

I just logged out and in again and now the Steam level on my profile is correct.
Title: Re: Issue(s)
Post by: willKane on March 25th, 2017, 07:57 PM
Quote from Nao 尚 on March 25th, 2017, 07:13 PM
@willKane, when you say you can't sync, did you press the Sync button and then nothing happened..? Or did you fail to find the button? Did you look for it? Did you expect an automatic import? Do you want one? (I'm not enthusiastic about doing that... ^^)
Nothing happens, and I'm on Chrome browser.
Title: Re: Issue(s)
Post by: devotee on March 25th, 2017, 09:06 PM
Quote from chaosfrost on March 25th, 2017, 06:40 PM
Stuck when tried to edit sent offer
https://lestrades.com/offer/460/
Oh, welcome to Lestrades!

Nice of you to come here and try to scam people with all those lowball offers including cheap Russian games(https://barter.vg/u/126/o/1302925/)... What you're doing would deserve its own topic.
Title: Re: Issue(s)
Post by: Quantum on March 26th, 2017, 01:42 AM
Some games don't seem to have ITAD links, in example: (sorry if this was already posted, didn't check the whole thread)
https://lestrades.com/game/26866/
Title: Re: Issue(s)
Post by: Forum Conventions on March 27th, 2017, 06:23 AM
https://lestrades.com/@arcanevortex/tradables/
https://lestrades.com/@arcanevortex/wishlist/
Title: Re: Issue(s)
Post by: chaosfrost on March 29th, 2017, 07:51 AM
Search is broken for me too. Yesterday it worked fine. Also when i click on notifications nothing happens, list doesn't appear,
Title: Re: Issue(s)
Post by: Pika! Pika! on March 29th, 2017, 08:19 AM
It still works fine for me. Are both of you logged in? If you are not logged in, I think most of the functionality is not available. In the upper left corner of the provided screenshot the 'Sign in with STEAM' icon is shown.
Title: Re: Issue(s)
Post by: chaosfrost on March 29th, 2017, 08:50 AM
There is no notifications if you not logged in :P
So yes i'm logged in
Title: Re: Issue(s)
Post by: Pika! Pika! on March 29th, 2017, 09:44 AM
Quote from Wraith on March 29th, 2017, 09:06 AM
Quote from Pika! Pika! on March 29th, 2017, 08:19 AM
It still works fine for me. Are both of you logged in? If you are not logged in, I think most of the functionality is not available. In the upper left corner of the provided screenshot the 'Sign in with STEAM' icon is shown.
Yes, logged in and it doesn't work for me.
Not sure what causes it in that case. Maybe it is a browser related problem or something related to security settings? I am using PCX Firefox. Then again, if it worked fine for you first, it seems as if some behind the scenes tweaking caused some sort of issue.
Title: Re: Issue(s)
Post by: PraX on March 30th, 2017, 02:10 AM
Local Time on profile page doesn't match Time Zone (Modify Profile -> Look and Layout). Correct time is displayed on right block (under Unread replies). Time zone in Date Registered, Last Active and Last post timestamps on profile page is correct when I logged in, incorrect (matches time zone of Local Time) when I browse profile page while logged out (checked from different browser).
Title: Re: Issue(s)
Post by: /u/humpaaa on March 30th, 2017, 03:37 AM
Cert is gone again
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 30th, 2017, 10:59 AM
Quote from chaosfrost on March 25th, 2017, 07:19 PM
This is why i went to edit that offer. Traded some game on barter then delete from my wants here, then want to remove that game from offers i sent earlier. Seems like that was wrong order.
Yes indeed. Although it should work now-- once you edit your offer it'll automatically remove your missing items. And technically I think you don't have to edit it either... I mean, it reminds me I should automatically remove games from offers when they're removed manually from your tradables. Or lock the 'Remove from tradables' button until you edit the offer, maybe... What would be best? The latter, I suppose..?
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 30th, 2017, 11:34 AM
Quote from ☺☺☺ on March 25th, 2017, 08:47 PM
I haven't been able to come up with explanation why this happens exactly because it is so strange why Barter scraper needs to access the items in db alphabetically sorted to cause this mess. It seems to me Barter must be able to scrape the correct title, because it must "know it": how else it could be that the wrong title is so consistently what these examples demonstrate?
I don't know either.
Anyway, I've written a small function to record alternative names from the Steam API, when they differ more than a ™ or ® sign (of course there are thousands, which is why I'm ignoring those). Currently I'm still showing the Barter-scraped name everywhere, except for game pages where I show the Steam API name by default, followed with the Barter name if it's different.
Note that these problems still happen (more frequently even?) in recent additions. e.g.: https://lestrades.com/game/33501/
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 30th, 2017, 11:38 AM
Quote from Wraith on March 27th, 2017, 06:19 AM
The tradables/wishlist links do not work when logged out. I can't share them publicly (like Barter's).
Fixed. Sorry about that one, I was returning a blank page for guests trying to visit /wishlist/ etc, but forgot to add an extra test for guests visiting another user's profile. In that case, well obviously there's something to show. :)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 30th, 2017, 12:00 PM
Quote from Wraith on March 29th, 2017, 06:04 AM
Also, the game search is not working for me. The auto search doesn't fire and pressing "enter" results in something like this: dummy_139185=helldivers which doesn't return anything.
That's actually the URL that shows up when you try to submit the name with JavaScript disabled..... *Or*, if JavaScript is stopped due to a script error.
The PHP parser on devotee's server is slightly different so it somehow didn't like either of the JavaScript minifier scripts I use (Packer and JSMin), so I had to fix bugs (or... adapt them...) in both scripts, and then recompile all scripts (which I forgot to do at the last minute).
Anyway, JS was broken for a few hours yesterday, which is why you had that.
A server move, with a completely different setup, is always a 'big' thing. Wedge behaves well on most servers, it just has a few hiccups which I guess I'm given an opportunity to fix. ;) That's the problem when you try to be compatible with all versions of PHP... At some point you end up having old code that breaks new features. Thankfully, it's always fixable. It's just harder when you don't sleep at night.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 30th, 2017, 12:06 PM
Quote from Pika! Pika! on March 29th, 2017, 09:44 AM
Not sure what causes it in that case. Maybe it is a browser related problem or something related to security settings? I am using PCX Firefox. Then again, if it worked fine for you first, it seems as if some behind the scenes tweaking caused some sort of issue.
To be very, VERY technical, because I did spend a few hours on that: Packer had a problem when executing a regular expression meant to remove comments from JS files, so I just took care of removing comments before giving control to Packer. Alternative minifier JSMin had problems of its own: some of my scripts cast strings as integers by adding a + in front of the var name (a classic JavaScript cheat), but this JSMin implementation is dumb and will convert a thing like "a + +str" (which is the equivalent of "a + (+str)") into "a++str" instead of "a+ +str". "a++str" is undefined in JavaScript, because it doesn't know if it should parse it as "a++" (increase a), "++str" (increase str then evaluate it), or "a+ +str". I guess JavaScript parsers are partly to blame, too-- if ++ is surrounded by two variable names, then maybe it means "+ +"... I fixed that bug by protecting all "+ +" calls before minifying, and then replacing the protected string with it again. A classic fix, too.
Title: Re: Issue(s)
Post by: joaoarena on March 30th, 2017, 12:14 PM
Can you please check the SSL? It says it expired yesterday, and is really hard to navigate the site with all the security warnings.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 30th, 2017, 12:25 PM
Quote from PraX on March 30th, 2017, 02:10 AM
Local Time on profile page doesn't match Time Zone (Modify Profile -> Look and Layout). Correct time is displayed on right block (under Unread replies). Time zone in Date Registered, Last Active and Last post timestamps on profile page is correct when I logged in, incorrect (matches time zone of Local Time) when I browse profile page while logged out (checked from different browser).
Ouch.. I could have fixed that when I was on Alex's server because I wasn't on the same timezone as the server ^^ Harder now.
I see that every member's time_offset is set to 0, that's weird. Although it may simply be a remainer of the SMF way of doing local times (using an offset). I think now it mostly relies on the timezone.
At Wedge.org I've checked out other profiles and they're good (I know one of the users is in India and his local time is ahead of mine). Here, I'm not so sure. It's probably not due to the server move then.
I'm too tired to look into the logic.
If anyone wants to...

Code where timezone is analyzed and used to generate a time offset[1]: https://github.com/Wedge/wedge/blob/master/core/app/Class-System.php#L235

Code where time offset is applied (e.g. profile page): https://github.com/Wedge/wedge/blob/master/core/app/Load.php#L1252

Let it not be said that this website's entire source code is hidden from view. :whistle:
 1. ...On each frigging page load?? An easy guess: I didn't write that part of the code! :P
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 30th, 2017, 12:28 PM
Quote from joaoarena on March 30th, 2017, 12:14 PM
Can you please check the SSL? It says it expired yesterday, and is really hard to navigate the site with all the security warnings.
Yes, sorry, I'm doing what I can.
It's like someone up there is saying, "Hey Nao, really, just give up on Lestrade's, I've been sending you so many signs this week..."
The certificate was generated last December, it's just my luck that I'm coming back to the server right before it expires, *and* on a day where devotee is unavailable. (He's not answering my Steam chat and texts.)
And since I don't have admin access to the server, there's no way I can fix it. :(

So, do like I do-- swallow your pride and use Firefox. At least it won't ask you to confirm the certificate on every page load! (Oh, I hate Chrome for doing that...)
Title: Re: Issue(s)
Post by: chaosfrost on March 30th, 2017, 12:52 PM
Quote from Lestrade 尚 on March 30th, 2017, 10:59 AM
Quote from chaosfrost on March 25th, 2017, 07:19 PM
This is why i went to edit that offer. Traded some game on barter then delete from my wants here, then want to remove that game from offers i sent earlier. Seems like that was wrong order.
Yes indeed. Although it should work now-- once you edit your offer it'll automatically remove your missing items. And technically I think you don't have to edit it either... I mean, it reminds me I should automatically remove games from offers when they're removed manually from your tradables. Or lock the 'Remove from tradables' button until you edit the offer, maybe... What would be best? The latter, I suppose..?
Well to me personally would be best to automatically remove a game from all sent active offers when i remove game from my tradables. And automaticaly cancel offers containing only one (removed) game. Since now lestrades and barter are separate and there is no automated sychronisation between each other i suppose there will be often situations when some tradable become unavailable if traded on one site while still present in offers on another site.
Title: Re: Issue(s)
Post by: joaoarena on March 30th, 2017, 01:26 PM
If just I knew that about firefox sooner... :whistle:
No worries.
Title: Re: Issue(s)
Post by: joaoarena on March 30th, 2017, 01:29 PM
chaosfrost, I second that "Well to me personally would be best to automatically remove a game from all sent active offers when i remove game from my tradables. And automaticaly cancel offers containing only one (removed) game." (quoting not working right now).
I have to manually open all offers to check if I proposed that game to anyone else, it is kind of tedious.
Title: Re: Issue(s)
Post by: Victor Jota on March 30th, 2017, 03:38 PM
Why my inventories are empty? I can't import anything :(
Title: Re: Issue(s)
Post by: Milouze on March 30th, 2017, 03:40 PM
Nao, I'm using a Chrome clone (SRWare Iron x64 portable latest release) and I noticed two issues while trying to quote here to reply:
http://i.imgur.com/S9M8DrN.png

So can't quote as it hangs in a "loading" state and the full editor is...broken ? Not sure how to describe what I'm seeing.

I originally wanted to comment on the certificate issue which impacts Edge, IE and my Firefox clone: PaleMoon as well. Let's hope Devotee can come back soon enough to look into this, which brings the backups (secondary admins) topic back on the table I guess :)


31-Mar-17 The editor seems to be working ok now, same for the quote. No more certificate errors as well. Nice :cool:
Title: Re: Issue(s)
Post by: beareryet on April 8th, 2017, 10:38 AM
I don't know what happened.. I think I might have broken the sorting in the wishlist. :(

I was adding in bulk from my following list, so in a format like this:
Quote
Game 1
Visit the store page
Stop following
 
Game 2
Visit the store page
Stop following
(Dunno if it helps, but it was done several times before reloading the page again, as the lines were too much for the server.)

And now it doesn't sort anything right. It's out of order for every category. Also, for each option selected in the drop box a number appears on the right side of it. So after multiple slections it can look like this: " 22 23 65 23 23 ". The dropox now shows options from the library, such as sorting by farmed cards, which I don't know if was a previous choice.

EDIT: The library sorting is messed too, and it seems like its options were swapped with the wishlist.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on April 8th, 2017, 11:54 AM
That's different issues you mention.
The number things is debug code I left over by mistake. I'll remove it as soon as I'm back on my pc. In the meantime you can use it to see how fast real-time sorting is. :-D (it shows time taken in milliseconds.) Sorting is disable on IE in lists (available only in offer creation) because it's 10x times slower (and only a couple of LT users are IE users so it's not worth bothering.)
Card sorting was always available everywhere. Since yesterday it's no longer shown on library pages because you're likely to have sorted those already anyway, so I've been using the space to show revoked statuses. (Note, I never showed cards on library pages, only the card sorting option, by mistake.)

I'm not seeing any errors with sorting on your page.

Just as a reminder, Lt will take a newline separated list of games in bulk. Please at least do the work of cleaning up lines like "visit the store page" manually... empty lines are fine.
Posted: April 8th, 2017, 11:49 AM

Okay I can confirm one clear bug, recent order is broken. It doesn't give me the same order for several items. I need to look into that.
Title: Re: Issue(s)
Post by: [slckr]robilar5500 on April 8th, 2017, 01:38 PM
Haven't read through all the pages yet, but it doesn't look like there is a way to start from scratch here without tying it to my now essentially defunct barter page, which was inaccurate even when I did log on there and didn't update my lists properly. How can I simply sync my Lestrades page to my Steam account without having it default to my barter page and related to that, how do I simply repopulate my tradables list manually? Without having to remove each of the 200+ in each category individually. Can you add a bulk remove function?
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on April 8th, 2017, 02:01 PM
Well you can re-add all your wishlisted items, only the new ones will be added. Tradables are more complex because I can't know if you have two copies from two different bundle stores (in which case I can't just increase quantity). I could however add a check box to allow you to ignore duplicates for your tradables added in bulk, like in the wishlist.
Steam wishlist sync will come later. The code is written but my last test didn't go well. Sometimes it's best to leave something aside until you've had a good night's sleep. ;)
Title: Re: Issue(s)
Post by: beareryet on April 8th, 2017, 03:09 PM
Quote from Lestrade 尚 on April 8th, 2017, 11:54 AM
snip.
Thank you, Nao.

I'm using chrome and can confirm that the ratio does not show correctly. This is my top commom from the wishlist:
Quote
Prey for the Gods                           0:102
Lumo                                           0:103
Farming Simulator 17                   0:103
Prince of Persia®                           0:105
The Elder Scrolls V: Skyrim Special Edition   0:105
Niche - a genetics survival game   0:107
Secrets of Rætikon                           131:14
Tomb Raider: Underworld           102:11
Contradiction - Spot The Liar!           0:110
Only those with zero tradables seem to be out of order.

These are instances from the library (top commom):
Quote
A 0:132 game (manually added) mixed with 1>ratios
(...)
Warhammer: End Times - Vermintide Sigmar's Blessing DLC   0:1
Age of Empires® III: Complete Collection                                1:123
(...)
Age of Mythology: Extended Edition      2:160   (1:80)
Eventide 2: The Sorcerers Mirror             1:78
Because it is precise for the most part I don't know if it's related, but sometimes I see something interesting.

A question on redundant lines on bulk import... does it overload the server or lead to some problem? The reason I don't want to clean up this kind of thing is the copious amount of work required to delete alternated lines of 250 items or so. I suppose I can use notepad and then excel to make it, but I'm just curious.

EDIT, always EDIT: are you sure the recent order is bugged? When added from 'followed, the games were in alphabetical order, so the most recent will be begin with the last letters. They don't follow the steam order of addition, but that could be on barter and the imports.
Title: Re: Issue(s)
Post by: [slckr]robilar5500 on April 8th, 2017, 05:23 PM
The check boxes would be sweet. Thanks Nao.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on April 8th, 2017, 05:49 PM
The problem was so weird. It was due to a server setting, and I don't know WHICH one.
When it was hosted on OVH, the server gave me proper precision on ratios. Now that I'm (happily) back at Dedibox, the server is unfortunately giving me scientific notation on small numbers when I try to output them. I fixed that by using a number_format and trim call, which is fast enough not to bother, but I'd like to be able to revert to the old way of doing it... The one that didn't require caling two more functions per ratio calculation. :P
So, because of scientific notation, numbers like 9.1E-5 would be considered the same ratio as 9.1, because I don't know, JavaScript is dumb..??
Quote from beareryet on April 8th, 2017, 03:09 PM
A question on redundant lines on bulk import... does it overload the server or lead to some problem?
No, it simply forces you to select 'Ignore this' whenever it tries to match a string that's not actually a game name...
Quote from beareryet on April 8th, 2017, 03:09 PM
The reason I don't want to clean up this kind of thing is the copious amount of work required to delete alternated lines of 250 items or so. I suppose I can use notepad and then excel to make it, but I'm just curious.
Yes, just a quick search & replace (or even search regex & delete) on notepad2 or notepad++ would work wonders.
Quote from beareryet on April 8th, 2017, 03:09 PM
EDIT, always EDIT: are you sure the recent order is bugged? When added from 'followed, the games were in alphabetical order, so the most recent will be begin with the last letters. They don't follow the steam order of addition, but that could be on barter and the imports.
I don't know, I need to look into this. Nudge me if I forget.
Quote from [slckr]robilar5500 on April 8th, 2017, 05:23 PM
The check boxes would be sweet.
Yes I'll work on that. If I don't forget. Right now I'm back in charge with my kid.
/menotices that your user name is unquotable in split posts...
Title: Re: Issue(s)
Post by: Kleidophoros on April 18th, 2017, 05:57 PM
I keep getting offers with games from my blacklist, am I doing something wrong? Can't see any setting for that.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on April 18th, 2017, 08:39 PM
Do... you have items in your wishlist and your blacklist at the same time..? Why..?
I'm not planning to take the blacklist into account until I get to implement sending offers for non-wishlisted items... Which will have to wait until I implement a few other things, too! :^^;:
Title: Re: Issue(s)
Post by: Kleidophoros on April 19th, 2017, 12:27 PM
Quote from Lestrade 尚 on April 18th, 2017, 08:39 PM
Do... you have items in your wishlist and your blacklist at the same time..? Why..?
I'm not planning to take the blacklist into account until I get to implement sending offers for non-wishlisted items... Which will have to wait until I implement a few other things, too! :^^;:
I have wishlisted some games at Steam for various reasons. Imported from steam to at barter; blacklisting games work there so you won't get offers for games you keep on your wishlist for reasons.
Then I imported to games lists from barter to lestrades, thinking it would work same way. Guess not. So I will have to remove them from my wishlist here I guess?
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on April 19th, 2017, 02:32 PM
No, I'm planning to make use of the blacklist-- it's just not an absolute priority. Back a month ago I'd have told you "it'll be there in a week", but I've learned to reduce my expectations for how quickly I work. Last few weeks have been complicated IRL and thus didn't have as much time to devote to the site as I wanted, but it still doesn't make me any less apprehensive to give an estimate to when a non-priority feature will be available. ;)
First I need to fix the ratio problems (it's 99% fixed, but that extra 1% bothers me), then enable the tag/list editing system, then we'll see!
Title: Re: Issue(s)
Post by: Akylen on April 26th, 2017, 08:41 PM
On a game page, if the game is added to tradables, still shows "Add to Tradables" button, even though it shows the table below with the quantity/tags. Happens with all my tradables.
Changing quantity didn't seem to alter the behaviour.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on April 26th, 2017, 08:57 PM
I changed that behavior for a reason... just click on the button and you'll get a pop-up with my explanation. ;)
Title: Re: Issue(s)
Post by: Akylen on April 27th, 2017, 02:19 AM
Quote from Lestrade 尚 on April 26th, 2017, 08:57 PM
I changed that behavior for a reason... just click on the button and you'll get a pop-up with my explanation. ;)
Got it! When there is one already added, the text of the button could change. Something like "Add more to tradables".
Don't know if it is possible to replace the popup with a tooltip. Just to avoid the intrusiveness.
Title: Re: Issue(s)
Post by: joaoarena on April 27th, 2017, 09:32 AM
I was puzzled by that too, if that is possible, is a good idea. :)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on April 27th, 2017, 12:27 PM
But a tooltip is something you might miss when you click it, while the popup won't let you proceed without clicking OK.
The thing is: the popup is there to *allow* you to add multiple copies, while *encouraging* you to use the Quantity tag instead. So it *is* meant to be slightly disruptive. The alternative would be to hide the button entirely :^^;:

I can reword the button though, but I already feel 'Add to tradables' is a bit long... Especially on mobile. (Reminds me I should shorten the 'Accept Offer' button to 'Accept' to make it all fit on one line due to the new Counter button... Okay, done.)
'Add to tradables', 'Add to wishlist' etc. is all inspired by the BVG UI because originally LT was the 'successor' to BVG. Now that it no longer is (and it's its own thing?), I could always reword everything... Or even remove the buttons, I don't know.
Title: Re: Issue(s)
Post by: Akylen on April 28th, 2017, 02:03 AM
The mobile website is something I never used so I wasn't counting on that ::)

Besides the case of the add button when there is 1 tradable added, I think they are fine and look nice on the desktop.

Can the mobile website use different buttons? That would help a lot. For example it is redundant to have add icon, type icon and description for mobile. Maybe remove the middle icon and keep either '+' or 'add'.

You mentioned removing the buttons. I can't see how would it work. What did you have in mind?
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on April 28th, 2017, 05:58 PM
Well, mobile can only hold 2 buttons on the same line (which is better than BVG than just does 1 IIRC), doesn't matter much how long their captions are...
By removing buttons, I had in mind other things like a text link (it's not gonna save much space...), or a dropdown with a list of possible actions, but honestly I'm just too used to these buttons to bother.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on April 30th, 2017, 10:38 PM
Apologies for the downtime-- I fixed a quick bug, uploaded the file, then went out for 15 minutes and when I came back, the site was down due to a parser error (misplaced bracket). I usually check my fixes before I leave, sorry again.
Title: Re: Issue(s)
Post by: Hig Hurtenflurst on May 1st, 2017, 01:53 PM
Minor issue -- when you perform any post action on a comment on a trade, the returned page shows a selection of public comments from all trades, not just the trade you are commenting on.  Reloading the page shows only the comments from the selected trade again.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on May 1st, 2017, 02:04 PM
Really? I'm not seeing that..? And I just did a test comment on an offer...
I'll check my code but what I see is definitely limited to the current offer. Maybe I'm using a different code path for the admin but i doubt so...
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on May 2nd, 2017, 12:28 AM
I haven't found any faults in my code.
Can you point me to an offer of yours that does that..? Maybe it's just the one.
IIRC I can (...everyone can??) comment on any offer, I could try & post to see if it occurs to me too.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on May 4th, 2017, 11:19 AM
Sorry, another downtime... One hour this time. :( :( :( Again this was due to a syntax error when uploading a file, and I didn't check the site after uploading it, and then leaving to watch American Gods... Ah well, these things happen during public betas. I usually catch them within a second because I check whether the changes worked, but in this case it was just adding a bracket and forgetting to add the matching closer... (Yes, very similar to the 15mn downtime from a few days ago.........)

PS: I only knew about the downtime because I was told by Steam chat, and I fixed it immediately. Feel free to message me on Steam in these situations, if the problem doesn't fix itself in the next minute!
Title: Re: Issue(s)
Post by: /u/humpaaa on May 4th, 2017, 11:47 AM
I must've seen the downtime in the last minutes then.
Saw it, got myself a coffee, and it was gone again. :D
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on May 4th, 2017, 01:35 PM
If it says parsing error, it's a typo on my side. Just give it 20 to 30 seconds. If it's still there, it's safe to say I'm not going to fix it until someone tells me or I get back to it.
My keyboard is AZERTY so the { } [ ] keys aren't positioned in a way that's convenient for developers. This is the #1 cause of problems on the site: bracket typos. I'm even considering buying myself a QWERTY keyboard...
Title: Re: Issue(s)
Post by: Akylen on May 4th, 2017, 11:55 PM
@Lestrade May I say you are using the wrong editor? Most of them do bracket matching hehe. Also there are linting tools for that.
I am sure you know that, but I had to mention hehe :whistle:
Title: Re: Issue(s)
Post by: Akylen on May 7th, 2017, 04:34 PM
In certain game pages the buttons are misaligned.
(https://s13.postimg.org/ydu23grgz/Screen_Shot_2017-05-07_at_13.42.53.png)(https://postimg.org/image/ydu23grgz/)
(https://s13.postimg.org/3xo55c5xv/Screen_Shot_2017-05-07_at_13.43.02.png)(https://postimg.org/image/3xo55c5xv/)
Title: Re: Issue(s)
Post by: Akylen on May 7th, 2017, 04:36 PM
It appears games on the blacklist are still being offered :(
Title: Re: Issue(s)
Post by: BigBlueWolf on May 7th, 2017, 06:14 PM
It appears that the local time field on my profile isn't using my confirmed time zone setting of
[UTC -8:00] Pacific Time (USA/Canada)

My current local time is May 7 @ 9:14 AM
On my profile summary page it says my local time is May 7 @ 6:14 PM
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on May 7th, 2017, 07:30 PM
Everyone else getting the same timezone problem..?

Akylen, where are they offered? In the 'unwished' area (reddish background) in the offer creator?

Misaligned buttons: you mean the 'Remove' button..? I'm not seeing that on my mobile browser. Anyone else can confirm?
Title: Re: Issue(s)
Post by: Akylen on May 7th, 2017, 07:36 PM
Location seems good to me. But there is no option to set the timezone that I could find.

@Lestrade here
https://lestrades.com/offer/2979/
I had Epigenesis in the blacklist.

Ahh! I can see the screenshot could be misleading, I should have clarified it. They are from a desktop browser (Chrome), not the mobile view.
All the buttons (tradables, wishlist and blacklist) are messed up.
To be honest looks good now, not sure if it was some kind of error, maybe it was generating the mobile page?
Title: Re: Issue(s)
Post by: /u/humpaaa on May 7th, 2017, 10:43 PM
Timezone seems to be okay for me
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on May 8th, 2017, 12:06 AM
Just go to your profile page and click 'Look and layout' in the profile menu. Or just add ?area=options to your profile URL. You'll see your timezone settings there.

Re: blacklist, I'm afraid I'm not seeing the problem. Is Epigenesis in your wishlist as well..? Because only unwished items will go through library+tradable+blacklist filtering, IIRC.

I'm also not seeing the same layout you do on the Epigenesis game page. I'm using Opera Desktop, which is based on Chromium so the rendering should be the same... Plus, your screenshot looks like a zoomed version, so apart from zooming on the page or using the Dev Tools mobile emulator, there's no way to get that. I suppose that was a one-time browser bug on your side, I'd say..?
Title: Re: Issue(s)
Post by: Akylen on May 8th, 2017, 12:45 AM
Quote from Lestrade 尚 on May 8th, 2017, 12:06 AM
Just go to your profile page and click 'Look and layout' in the profile menu. Or just add ?area=options to your profile URL. You'll see your timezone settings there.

Re: blacklist, I'm afraid I'm not seeing the problem. Is Epigenesis in your wishlist as well..? Because only unwished items will go through library+tradable+blacklist filtering, IIRC.

I'm also not seeing the same layout you do on the Epigenesis game page. I'm using Opera Desktop, which is based on Chromium so the rendering should be the same... Plus, your screenshot looks like a zoomed version, so apart from zooming on the page or using the Dev Tools mobile emulator, there's no way to get that. I suppose that was a one-time browser bug on your side, I'd say..?
Probably a bug on my side. If it happens again I will let you know.

Epigenesis is on my wishlist and blacklist. I thought if the game is on the blacklist no matter what it wouldn't be offered.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on May 8th, 2017, 01:27 AM
No, I simply give a different priority to the blacklist compared to BVG. Wishlist always has priority to me. The 'extra' tag is only there to stop LT's from telling you that a wishlisted item is already in your library.

It's a personal choice, but I think it makes sense. If you have something in your wishlist, why would you not want to see it in offers? Plus you can always add the 'no offers' tag if you don't want offers for it...
Title: Re: Issue(s)
Post by: Akylen on May 9th, 2017, 01:09 AM
You are right I guess. I am making use of the 'no offers' tag now.


The reason for using wishlist + blacklist is I want to track the game progress, but don't want to trade the game. Ex: free games, games with low score and/or early access.
Title: Re: Issue(s)
Post by: Kleidophoros on August 23rd, 2017, 12:23 AM
I would once again post about wishlist+blacklist not being able to be offered.
I want to keep track of some games but don't want any offers so adding them to my blacklist and since wishlist is synced from steam automagically I can't just remove them from wishlist here.
Will check the no offer tag. Will it stop people from offering me the game or is it just a warning people can ignore?
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on August 23rd, 2017, 01:17 AM
Yes, it will stop them from offering the game entirely. It'll be grayed out *and* disabled (while blacklist only grays it out without disabling it.)

I'm really, really not a big fan of blacklists. I'd rather ditch those later, replace them with custom 'generic lists' where you can choose a list name (such as 'Blacklist' if you're inclined), but that will not have much impact on offers, simply help you sort out your games. (For instance, adding a "Favorite games" list where you could freely add your favorite games, whether or not you have them in another list. That'd be something.)
Title: Re: Issue(s)
Post by: Kleidophoros on August 23rd, 2017, 09:06 AM
I don't understand why you are against the blacklist this much but sure no offer tag will work for me.

Btw the pop-up selection thingy when I am looking at a list and selecting multiple titles prevents me from seeing the entries on the very bottom of the page.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on August 23rd, 2017, 10:17 AM
Quote from Kleidophoros on August 23rd, 2017, 09:06 AM
I don't understand why you are against the blacklist this much but sure no offer tag will work for me.
Mostly because many users add tons of DLCs to their blacklist just because Barter is unable to let them mark a DLC as owned. I actually started doing that back in the day. The first thing I did with Lestrade's is allow users to mark a game as owned if it's registered as a DLC or a package. Thus making blacklists useless for me. Which is why I later came up with the 'no offers' tag, and my surprise at seeing Barter come up with the same tag independently on the very same day. (Great minds think alike? :P)
Anyway, there are still like a dozen 'offenders' at Lestrade's who have over 5000 titles in their blacklist, taking up the majority of the table's content. This just strikes me as inefficient, that's all. I'll probably contact them individually and ask them to clean up their blacklist eventually before I turn blacklists into generic lists. You'll see, it's going to be a good feature. So much work left to do, and so few users left to enjoy it... :( (Well, still a 1:4 ratio compared to Barter, as in the last couple months. I'm working on ways to increase that soon enough.)
Quote
Btw the pop-up selection thingy when I am looking at a list and selecting multiple titles prevents me from seeing the entries on the very bottom of the page.
I was going to reply "Scroll the page dummy!" and then I understood what you meant. I'll look into it.
The problem wasn't apparent to me because at the end of every page I have like 150 pixels worth of debug data showing up (as I'm the admin, obviously). So it never hides anything...
Title: Re: Issue(s)
Post by: Kleidophoros on August 23rd, 2017, 12:30 PM
Not entries but entry, it hides the lowest entry at the bottom.
If the " My Wished copies (1 selected - deselect)" part was moved to the right it would show I guess. Or just adding a bit of empty area to the bottom.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on August 23rd, 2017, 03:26 PM
Yeah I'm gonna add some space but I don't like empty-- I like useful. Anyone got an idea of what I could put in there...? :-/
Title: Re: Issue(s)
Post by: Kleidophoros on August 23rd, 2017, 03:56 PM
Move it all/the higher bit [My Wished copies (1 selected - deselect) part] to the middle?
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on August 23rd, 2017, 05:55 PM
No, that'd be even messier, especially since 99% of the games on your list are fine with the box popping up below them. I did my best to make it usable (mobile version is far from being great but at least it's more usable than BVG's own tagging system so I'm happy enough for now.)

I'm trying to find what I can show below... Maybe some kind of stats, I don't know..? What kind of stats would you like to see there? Like, ratios and things?
Title: Re: Issue(s)
Post by: Kleidophoros on August 23rd, 2017, 06:04 PM
Quote from Lestrade 尚 on August 23rd, 2017, 05:55 PM
What kind of stats would you like to see there? Like, ratios and things?
Don't you mean "What kind of stats would you like not seeing there?" as it would be hidden if anything is selected :)

Maybe just practical stuff? A Back to top button? Repeatin the top menu? Filter, sync buttons?
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on August 23rd, 2017, 07:00 PM
Well, it's likely most of the time nothing will be selected, right..?
Back to top button is already there. Just click the mustache ;)
Top menu nah. But if I had a breadcrumb at the top, I could repeat it at the bottom. Unfortunately, I don't. (I mean, I could add one, I just don't know that it's useful. I don't know.)

Maybe I could repeat the list of lists (tradables etc), but that'd make people wonder why the list isn't repeated on non-list pages.
Filter buttons are to be shown at the top so they're really prominent. Most of the filters are for premium users only though. ^^
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on August 23rd, 2017, 07:08 PM
I implemented a dynamic solution. Does it work for you?
Title: Re: Issue(s)
Post by: Kleidophoros on August 23rd, 2017, 08:36 PM
Yeah it seems to work when scrolled after selection.
Title: Re: Issue(s)
Post by: A1ice[useless] on September 5th, 2017, 10:40 AM
— Ignore other games, only re-add this one, with infinite (∞) quantity

An Error Has Occurred!
Session verification failed. Please try logging out and back in again, and then try again.

Logging out and back doesn't help
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on September 5th, 2017, 03:02 PM
Hmm yes, looks like I forgot to add the session data to that link. (This is to combat account/session hijacking, BTW.)
Should work now?
Title: Re: Issue(s)
Post by: A1ice[useless] on September 9th, 2017, 12:56 PM
Quote from Lestrade 尚 on September 5th, 2017, 03:02 PM
Should work now?
Yes.

Now edit offer, but don't see Send button
After "preview" page just refresh
(https://i.imgur.com/HrxSi6B.jpg?1)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on September 9th, 2017, 09:14 PM
Sorry I've been offline most of the day. I'll look into it within an hour.
I also noticed offer creation was slightly broken, in that maybe it's not possible right now. Possibly due to a commit I shouldn't have made, mixing up the old preview and new preview systems. Ouch. That hurts. Sorry about that.
I think I'll just go full on new system tonight, and I'll fix the remaining issues later.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on September 9th, 2017, 09:39 PM
I've uploaded the admin version of my trick, it's working well for me, hopefully for you too.
Enjoy the increased speed :)
Title: Re: Issue(s)
Post by: A1ice[useless] on September 11th, 2017, 02:49 PM
Problem: if you create offer - it will be 1:1, so your need edit it after creating
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on September 11th, 2017, 04:47 PM
Ah, that's exactly the kind of thing I feared could happen... hmm. I'll look into it. (Note, though, that I'm aware some people prefer having a 1:1 by default but I don't.)

One of the other things is that if you reload the page while creating the offer, it won't remember the quantities either. I'd need to save that as well.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on September 11th, 2017, 06:15 PM
OK, got what you mean. Whatever you choose, it's always a 1:1 at submit time.
Unable to find reason for now. Will keep looking.
Title: Re: Issue(s)
Post by: Flying Potato on September 19th, 2017, 09:59 AM
Hi, I got a problem : when I click on "Send offer", nothing happens. Tried on several browsers and still the same issue :/
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on September 19th, 2017, 07:30 PM
Working for me. Anyone else?

Also, apologies for the site giving an error message for over an hour... I was right in the middle of fixing a bug on the homepage and hit a colon instead of a semicolon on my keyboard, uploaded the file and then realized I had to hurry to get my kid from school. Happens sometimes. Really sorry, I feel bad when these things happen, but I didn't even get a Steam chat message about it, otherwise I'd have gotten a notification and would have fixed this half an hour ago when I went back home.
Title: Re: Issue(s)
Post by: Drebian on September 19th, 2017, 08:22 PM
Quote from Lestrade 尚 on September 19th, 2017, 07:30 PM
Working for me. Anyone else?
I did a test offer and it's working fine for me.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on September 19th, 2017, 08:48 PM
Yeah so it's probably a problem not related to my code. Would need a step by step guide then...
Title: Re: Issue(s)
Post by: Flying Potato on September 19th, 2017, 09:34 PM
There we go !
I go on the "Matches" tab, then click on Send Offer.
I select the game I want to trade, and the game I want to have, then "Preview Offer".

The trade detail boxes appear, and when I click on "Send offer", they disappear for a very short while and then reappear, but nothing happens.

If you need any more info, I'll try to be as precise as possible.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on September 19th, 2017, 11:46 PM
Yes, because it's obviously not happening for anyone else.
When was your last successful 'Send offer' that you can remember?
Oh wait, I just checked, you're a newbie, you haven't sent anything yet.
The 'they disappear for a short while' thing is normal. It's a visual clue that the page is being reloaded with Ajax (so that it doesn't have to reload the list of games from both users at the very top of the page.) It normally ONLY happens when clicking 'Preview offer'. Clicking on 'Send offer' should NOT show a fade-out effect, instead it'll take you to the finalized offer page, with the 'Edit' and 'Cancel' buttons. (Hmm, maybe I should add a visual clue that the offer was successfully sent, BTW...)
So, it's important that you confirm you're seeing the fade-out effect even on the 'Send offer' button, actually.

I develop the site under Opera, which uses Chromium (Chrome) as its engine. That should handle a good 60% of users. The site is also confirmed to work fine in Firefox. IE, normally should work on recent versions... Can't make promises for IE 6-7. Then again, they have like a 0.1% market share altogether...
Title: Re: Issue(s)
Post by: Flying Potato on September 20th, 2017, 12:04 AM
The fade-out effect appears when clicking on '"Send Offer" unfortunately.
Well, I'm on Firefox 55.0.3 running on Mac OS, not sure if this can help. Also tried with Safari with no luck.
I'm downloading Opera right now, going to test that first thing tomorrow and will report here !

Edit : Well, couldn't wait, and everything works smoothly on Opera. :)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on September 20th, 2017, 12:41 AM
Plus, good opportunity to try out Opera :P (I'd recommend installing Sidewise as well. It's a good vertical tab list with plenty of features for power users.)

Maybe it's a bug I recently introduced in Firefox, then... Can anyone else try it out? It's not currently running on my PC and I'm busy on other things and I have too many tabs in Firefox and it'll take a while to load and... Ah well, anyway!
Title: Re: Issue(s)
Post by: Kleidophoros on September 24th, 2017, 12:16 AM
Cant tag tradables as steam inventory gift. says updated, nothing happens.
Or I cant see the icon maybe, dunno.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on September 24th, 2017, 08:27 PM
Maybe you can't see it yes. I recently replaced the steam icon with a svg version that's 30% lighter -- nothing of interest but I just like using svg where possible. There's a fallback for old browsers so ...what's your browser?
Posted: September 24th, 2017, 07:08 PM

Addendum: I can see your steam key icons even on an old browser.
Title: Re: Issue(s)
Post by: Kleidophoros on September 24th, 2017, 09:11 PM
Firefox 55.0.3 - 32-bit, latest version. (Weird, I thought I had 64 bit version.)
Just tried on Chrome, I can see a green icon.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on September 25th, 2017, 12:42 AM
Fixed, indeed was a problem with Firefox being stricter with # signs found in the SVG. It needed them to be URL-encoded.
Posted: September 25th, 2017, 12:35 AM

(The problem was mostly happening because I hacked my CSS to be able to set a SVG color depending on night mode being enabled.)
Title: Re: Issue(s)
Post by: Milouze on October 12th, 2017, 07:29 PM
My first try to send an offer from mobile
https://lestrades.com/offer/?u=574;g=257202,333488,333485,333496,333470,251965

Can’t « send offer », page loops with no error message :(
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on October 12th, 2017, 07:39 PM
With all browsers?
Runs fine on my Chrome Mobile...
Title: Re: Issue(s)
Post by: Milouze on October 12th, 2017, 10:34 PM
That was my first try. Tried again now on my iPhone 7 (so Safari it is), still the same.
It's frustrating: I can list the matches, open a new tab to create the offer, preview it and then nothing else.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on October 13th, 2017, 05:42 PM
Anyone else?

Can't debug without an iPhone...
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on October 20th, 2017, 01:12 PM
Apologies for the website being down about half an hour.
I executed a long query by mistake in my admin panel, and for some reason I didn't have a slot left to launch a process to kill all other processes. I ended up writing the script in PHP and brute-forcing the kill.
(Heck, I even changed the database password, hoping it'd force the kill... Nope, it didn't.)

PS : Milouze, ça va mieux ton problème d'iPhone, "vieux" ?
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on October 30th, 2017, 10:33 PM
Known issue, talking to myself:

- Create an offer, send it.
- Click Edit offer.
- Reload page.
- Submit.
- A new offer is created, older offer remains in Editing mode.

This is due to the recent AJAX implementation... I'm not keeping the offer ID around at that point. Shouldn't be too hard to fix but I can't be arsed for now.
Title: Re: Issue(s)
Post by: dys on October 31st, 2017, 04:21 AM
In Matches view, my custom properties are teal (color: #3eb2cb;), and the other trader's custom properties are yellow (color: #ffc833;).
Except for the other trader's Estimated Trading Value, which is also being shown in teal (color: #3eb2cb;).
(https://i.imgur.com/bRcNVav.png)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on October 31st, 2017, 12:42 PM
Should be fixed now. I never noticed the bug because it was untestable for me-- the only users to use custom values so far have been me and Zomby (with whom I also have only Subnautica in common... Gosh I nearly gave away that game to a scuba-diving friend for fun, didn't realize it'd be the only way for me to 'reach' other traders lol. Maybe I should add imaginary popular games to my tradables now.)
Guys, start tagging tradables & wishlists! I find it much simpler to tag a game "$4" than manually adding some kind of "CS:GO key x2" tag or custom note... As for wishlisted entries, I tend to tag shit games with a custom value of $0.05 or less, to indicate that I'm not willing to trade more for it than another worthless game.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on October 31st, 2017, 01:08 PM
Okay, I also fixed the issue with submitting offers above... That was more complex than I thought. Required a few changes here and there. Hopefully that doesn't create NEW problems, lol.
Also a limitation: I'm not storing quantities, so if you just reload the page, quantities will be reset to the actual amount of items in your offer, i.e. "5 out of 5" instead of "4 out of 5". I can fix that too, but I'm in less of a hurry. I hate touching up on my offer code... It's just so complicated with the AJAX implementation. (But it's so cool, too.)
Title: Re: Issue(s)
Post by: eagletorch on November 4th, 2017, 07:19 PM
I can't edit or make new offers on mobile on either safari or chrome on iOS. I like hat he layout was responsive, maybe a lot more QA testing needs to be done on mobile devices
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on November 5th, 2017, 03:16 PM
I do at least half of my offers with Chrome for Android, I don't remember any recent changes that might hurt.

Your description isn't enough. Can't edit? What does it mean, there's no Edit button? Or the button doesn't do anything? Or it loads a new page, but not the Edit page?
Title: Re: Issue(s)
Post by: eagletorch on November 6th, 2017, 10:27 PM
The page loads, but clicking the Edit button doesn't do anything.
Title: Re: Issue(s)
Post by: eagletorch on November 12th, 2017, 05:09 PM
Still can't send any offers on Chrome on iOS
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on November 13th, 2017, 12:26 AM
Oh yes, forgot about that sorry...
Mostly because I was unable to figure out your issue.

I've removed a small bit of code that disables the button after a press. Please tell me if that fixes it... (It's only removed if you're on iOS, BTW. If it still doesn't work, I'll disable it for everyone for testing purposes.)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on November 17th, 2017, 09:19 PM
Bump @eagletorch -- how's it working now..?
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on November 18th, 2017, 11:48 PM
Sorry, I'm not even sure what your problem is, and why it's happening at all..? (I mean, "Remove from library" shouldn't even show up during a BVG sync? Only when syncing with Steam..?)
My syncing code, AFAIK, is solid enough to accomodate for all situations.
Although, to be clear, removing library items probably won't work because Steam will re-add them later if it's in your Steam library according to their API data. You can only remove a library item manually if it's a DLC or package *or* it was revoked and marked as such. If it's not seen as revoked, then it means you still have those, no..?
Title: Re: Issue(s)
Post by: nhex on December 10th, 2017, 05:43 AM
I can't send any trade offers - I click "send offer" which is green, and something happens, but the offer doesn't get made.
Title: Re: Issue(s)
Post by: /u/humpaaa on December 11th, 2017, 07:06 PM
Misaligned Icons:

(https://i.imgur.com/kakhhBw.png)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on December 11th, 2017, 11:59 PM
I'm having trouble with the '+' (More) button because I wanted to do it the way it was before, but entirely in CSS (which allows for better results in high-DPI screens), but it's used in a lot of places and with different CSS rules so it's probably not a great idea, I should probably do it in SVG instead.
That Modify button, however, is terrible on your browser... Seriously, what's your browser? Why is it so huge on it?
I hate it that some browsers (here's looking at you Firefox...) use emoji by default instead of rendering them in plain text. I don't even understand why they don't fall back to plain text when a 'color' rule is used on the CSS. I want monochrome versions!
Here's a sample of what it's supposed to look like...
Posted: December 11th, 2017, 10:53 PM

(This was getting annoying, so I just reverted to the old More icon for now...)
Title: Re: Issue(s)
Post by: /u/humpaaa on December 12th, 2017, 08:05 PM
That's Chrome 63
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on December 12th, 2017, 09:26 PM
I'll need the OS/device combination, too...
Title: Re: Issue(s)
Post by: /u/humpaaa on December 12th, 2017, 09:38 PM
Win10 x64 // Chrome 63.0.3239.84 64 Bit
Don't think i have any addons that would interfere, scriptsafe  / ublock are disabled fpr lestrade
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on December 12th, 2017, 09:59 PM
Hmm... I don't have W10 anymore (sucks too much IMO, although I liked the new UI), but the missus has it, so I'll have a quick look.
PS: no need to disable ublock for me, I don't like intrusive ads myself, and you'll never find any on my websites. In fact I'm unlikely to ever add ads here at all. ;)
Title: Re: Issue(s)
Post by: /u/humpaaa on December 12th, 2017, 10:08 PM
Did you change something? It's fixed for me
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on December 12th, 2017, 10:17 PM
Okay, back from my little session on W10...
- Site is looking bad on Chrome indeed. All icons are replaced with a custom font that's ugly as hell. Seriously, the really nice 'Home' icon looks that bad now. Isn't Google rich enough to afford designers..?
- Her laptop is using a custom 150% size font because of the very high DPI on her screen. As such, I can't really 'test' font sizes there. It's looking okay, though.
- Ironically, Edge (or was it IE11, I didn't really check) uses the default (Segoe UI Symbol) unicode symbols, and looks 'as intended'. Can you test on it? I'm sure you'll find it to be nicer.

I'm currently rewriting the CSS to use the preferred font on these icons. I'm afraid it won't help with mobile devices, but at least Windows should be OK.

:edit: I changed stuff, but 8 minutes ago..? I don't think I changed anything that could have fixed your Edit icon. (??) :edit: Oh wait, no, it's just that I introduced a new SVG icon in its stead. I don't know if I'll keep it though.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on December 13th, 2017, 01:12 AM
Okay, I think I'm done with icon fixes. Please make sure to post here if you see anything weird!
Also, I'm unable to test on Linux and MacOS, as well as most mobile devices. Any volunteers..?
Posted: December 13th, 2017, 12:20 AM

Also, iOS users could tell me whether or not forum posts like these show up normally, without any weird whitespace. (Chrome for Windows has an option to simulate an iPad Pro and totally screws up the layout...)
Title: Re: Issue(s)
Post by: /u/humpaaa on December 13th, 2017, 01:23 AM
Everything is fine on chrome, great job
Title: Re: Issue(s)
Post by: Akylen on December 13th, 2017, 01:25 AM
macOS is fine here
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on December 13th, 2017, 08:23 AM
Phew. All's left is mobile. I can't really test with my phone because I modded it to replace all emoji's with monochrome equivalents months ago. (I just hate emoji.)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on December 18th, 2017, 01:52 PM
Apologies for the downtime today. The server was unresponsive for about an hour after I failed to shutdown a SQL query I was running that was badly formed. Basically, it works by joining two tables to get the relationship between two columns, then I simplified it to remove the need for the join, except I forgot to remove it, so it was joining the tables and, for every proper match, it was duplicating them by the size of the table, which happens to be the games database, so instead of doing a ~1 second query, I was looking here at a 60.000 second query that was also locking the table.
Usually I'd just rename the table so that the query is ended by force, but this time it didn't work. I'm not sure why.
Anyway-- these things happen during development.

I would love to be able to restart the server by myself, though... Not having SSH access can be annoying. Then again it's free hosting for me, and since the site is a free service, it's the best I can afford for now I suppose. (Plus-- great server!)
Title: Re: Issue(s)
Post by: /u/humpaaa on December 20th, 2017, 03:01 AM
Whean creating an offer:
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on December 20th, 2017, 09:36 AM
Oops! Typo when adding item types (DLC, video...) to offer creations, sorry ;)
Title: Re: Issue(s)
Post by: /u/humpaaa on January 22nd, 2018, 10:13 PM
Barter redesigned the page.
This broke importing of tradables / wishlist
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on January 24th, 2018, 05:58 PM
Did my fix work, BTW..?
Title: Re: Issue(s)
Post by: /u/humpaaa on January 24th, 2018, 08:16 PM
Yes, it's working again =)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on January 24th, 2018, 09:13 PM
Their site didn't have internal changes, it simply removed a line at the bottom of the page and that was enough to break the scraper. ;)
Title: Re: Issue(s)
Post by: Kleidophoros on May 6th, 2018, 04:22 PM
Can't add this to my tradeables.
https://lestrades.com/game/2286/
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on May 7th, 2018, 08:35 PM
Free to play games aren't addable. This is done to avoid errors. Why should I allow for this one to be added..? Just in case.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on May 7th, 2018, 08:38 PM
Hmm was it actually free to play at one point or was this a mistake at steamspy..?
Title: Re: Issue(s)
Post by: Kleidophoros on May 12th, 2018, 08:14 PM
No idea if it was free to play or not.
It's just a collector's item at this point; a removed game.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on May 12th, 2018, 10:26 PM
My best guest is that steamspy had it as free to play by mistake at one point and later fixed it. Unfortunately their API changed as well and tag retrieval is currently on hold. I can add new tags but can't remove old ones. Which is usually not a problem...
Title: Re: Issue(s)
Post by: Akylen on June 5th, 2018, 03:00 PM
Fallen Enchantress Ultimate Edition should point to
https://store.steampowered.com/bundle/1484/Fallen_Enchantress_Ultimate_Edition/
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 5th, 2018, 08:34 PM
It's a bundle ID (i.e. you only pay for stuff you don't own), AFAIK these aren't supported directly. I don't remember for sure. You'd need to ask Barter to fix the link. But if it doesn't have a matching sub ID, it's gonna be hard to integrate.
Title: Re: Issue(s)
Post by: LuiGi on June 6th, 2018, 11:23 PM
The "Full list" option when creating an offer isn't working properly? Or it's just something related to my web browser (Google Chrome)?
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 8th, 2018, 11:11 AM
Thanks for pointing it out :) I don't use the Full list option generally. It was due to an inversion between two parameters in a function call that I wrote too hastily I guess.
Title: Re: Issue(s)
Post by: LuiGi on June 28th, 2018, 02:56 PM
The previous issue seems to be fixed, but I'm not sure if 100% fixed. When creating new offers the "Full list" option now is working well, but when countering a received offer I clicked on Full list and something went wrong. Could you try it? Thanks =)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 29th, 2018, 01:10 AM
Ah... Yes indeed. I understand why.
Countering here is doing in a 'novel' way, some data is passed invisibly in the post, but following an explicit link like the 'Full list' one will empty the post area and thus make it look as if the offer was reset. Meh...

I suppose I could force 'full list' on any counters, what do you think..? Don't really wanna rewrite my counter code either way...
Title: Re: Issue(s)
Post by: LuiGi on July 2nd, 2018, 03:04 AM
As you prefer, it's not a big problem. Knowing "Full list" works perfectly in new offers, we can easily decline and create a new offer for countering in order to use the full list option when needed.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on July 2nd, 2018, 03:11 PM
Yes, but obviously it's not satisfying to me...
Title: Re: Issue(s)
Post by: /u/humpaaa on July 3rd, 2018, 06:16 PM
Oh i know that feel. The developers itch... :D
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on July 3rd, 2018, 09:46 PM
Yeah, but realistically, I can't devote too much time to a website that's still struggling to increase it's userbase after a year.

Heck, even barter.vg has been stable or dropping in numbers in months-- I remember it used to be 1400 at its best and even after it got linked at gamasutra (and other sites) for its achievement-based user library stats (clever stuff, didn't even know the admin had that), it's still struggling.
Still, I'd love to have an active user base of 1300... Even 1000 would be great :-P
Title: Re: Issue(s)
Post by: Akylen on July 8th, 2018, 06:16 PM
Noticed a couple dozens games just show as '(Steam error)' for these publishers:
https://lestrades.com/studio/297/
https://lestrades.com/studio/97/


Not sure if it is possible, but maybe you could put a batch job to cleanup error entries?
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on July 8th, 2018, 11:01 PM
There is actually a batch job running several times a day to recover lost titles from the BVG database. In your particular case the DLC names can be gotten through SteamDB, which I'm not scraping at all. I don't know if BVG gets its items from SteamDB (or SteamKit FWIW), but I suppose at some point it'll update the DLC names and I'll automatically reflect that on the site.
Well, given the number of DLCs Heart of Iron IV has, I'm not surprised it's such a mess...
Title: Re: Issue(s)
Post by: Akylen on July 9th, 2018, 02:02 PM
Yeah. Paradox really entered in their own paradox of DLCs  :lol:
Title: Re: Issue(s)
Post by: Akylen on August 8th, 2018, 02:26 PM
This one says "delisted" - but it's not.
https://lestrades.com/game/14011/
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on August 8th, 2018, 10:14 PM
It's not saying delisted for me..?
Title: Re: Issue(s)
Post by: Akylen on August 9th, 2018, 12:07 AM
Super odd. This is how it's showing:
(https://s8.postimg.cc/pi13igf1x/Screen_Shot_2018-08-08_at_23.04.58.png)(https://postimg.cc/image/6cxu8p0dt/)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on August 9th, 2018, 11:27 AM
That's a different issue than what I was looking into...
It means your key was revoked. Do you still have the game in your steam client?
Title: Re: Issue(s)
Post by: Akylen on August 9th, 2018, 01:43 PM
Nop. I think I added the game when it was free for a weekend, but didn't get the time to play it.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on August 9th, 2018, 03:01 PM
There you go. ;)
Title: Re: Issue(s)
Post by: Akylen on August 10th, 2018, 12:00 PM
It still thinks it's on my library though.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on November 17th, 2018, 04:57 PM
(Old topic!)

Yeah it does, because it can't really know if it was revoked or just borrowed.
IIRC, you can actually manually remove the game from your library from within the game page. As long as it's marked as 'delisted', you can do it.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on October 1st, 2019, 03:29 PM
Note: Lestrades.com was down for 12 to 18 hours, I'm not sure how long exactly. When it started I was already in bed early due to headaches, and when I woke up I was unable to get in touch with the server admin (devotee) to ask him to relaunch the MySQL server which was the issue here.
I guess I finally found an e-mail address that works ;)

I need to consider moving to another server, though. Not being able to reboot it when I'm made aware of an issue isn't great. This wasn't the case when I started the website back in 2017, and there's no reason it should be a problem today. ;)

I'll look into it.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on October 28th, 2019, 11:20 PM
Guys, do you think it's worth moving to another server..?
I mean the other server might be a bit slower, although it's very close in specs it's also 8 years older (!).
Also, it'd take me time to reconfigure everything. :-/
But the pros would be:
- No more crashes, hopefully, and certainly not long ones,
- Freedom to install more stuff for my own development,
- More disk space available, so no "disk full" errors, and... I get to improve the database scraping system, by caching pretty much everything.
Title: Re: Issue(s)
Post by: Akylen on October 29th, 2019, 12:19 PM
Yeah I think you should give it a try. VPS are cheap nowadays. No need to use an 8 year old server.

Linode have good prices
https://www.linode.com/
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on October 31st, 2019, 06:56 AM
Way less value than dedibox and OVH (kimsufi, or their cloud stuff.)
I'm sticking to French companies anyway. The only time I dealt with a popular web hosting in the USA was a disaster.
Title: Re: Issue(s)
Post by: Akylen on October 31st, 2019, 08:34 PM
I understand that. Well if you change your mind, I've also heard good things of Hetzner
https://www.hetzner.com/
Title: Re: Issue(s)
Post by: Annoyer13 on November 1st, 2019, 01:18 AM
Kimsufi vps'es are usually pretty good if we're talking about ovh.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on November 2nd, 2019, 02:14 PM
Yes we are.
The beta version of Lestrade's was actually running on such a vps, but it quickly moved to a dedibox server. Performance was doubled overnight.
Title: Re: Issue(s)
Post by: Akylen on November 14th, 2019, 02:06 PM
I've noticed the font changed recently. Not entirely convinced! I think the old one was better and smoother.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on November 18th, 2019, 03:39 AM
I've been using Open Sang for months here (custom admin settings ;)), and thought there was no reason not to apply it to everyone else (except in mobile mode, for bandwidth reasons.)
Why the issue..? Very readable to me.
Title: Re: Issue(s)
Post by: Randoman on November 18th, 2019, 09:24 AM
Can you please contact my email about removing one of the games you have listed from the site? It's one of my own personal projects that's directly attached to my name that I've removed from Steam and am actively trying to disconnect with, hence the lack of game mention in this reply. Thank you for your time - TempDescRemoval@mail.com
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on November 19th, 2019, 04:06 PM
I have no idea what you're talking about...
The games listed at Lestrade's are from a database of Steam games, available or not. I haven't found any game named 'Gio-something', and I don't see why the presence of your ex-game on this database (which is also there to help users manage their libraries) would be a problem for you. Rule 38: if it exists, there's a database entry for it.
Title: Re: Issue(s)
Post by: Akylen on December 14th, 2019, 04:09 PM
Sharing here, that since a few days ago when I clicked on my messages it wouldn't open. I realised it was my adblocker. Disabling it resolve the issue.
It is odd, since are no ads on the website.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on December 17th, 2019, 01:21 PM
Yeah, I don't believe in ads. (I believe in money, I just don't believe in seeing it in my hands :lol:)
Possibly a browser bug..? Because I'm not seeing any problems here.
Title: Re: Issue(s)
Post by: /u/humpaaa on December 19th, 2019, 11:35 PM
SSL cert expired.
Not on Certbot-autorenew?
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on December 23rd, 2019, 01:20 AM
You'd have to ask Devotee, but he's not much around here...
I sent him a message on Steam, hopefully he'll see it.
It's only the second this has happened since the site opened, BTW. So I'm guessing this might be quite specific.
Title: Re: Issue(s)
Post by: devotee on December 29th, 2019, 09:57 AM
Should be fixed now.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on December 29th, 2019, 10:45 AM
Ah! At last :)
Were you on a Christmas break? ;)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 14th, 2020, 11:38 PM
Apologies about the downtime today... I wrote a faulty SQL statement that was missing a safeguard, and ended up running it a million times (!) more than needed. Oops! Had to wait until the query finished, reset the database, and then run the fix query which just took a second or so... Silly me.
Title: Re: Issue(s)
Post by: Akylen on March 16th, 2020, 12:05 AM
I noticed a few exclusive steam bundles that include a GOG game or two:
https://lestrades.com/bundle/7800/ - Space Robinson: Hardcore Roguelike Action

This messes up the stats not only mine, but site's too.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on March 22nd, 2020, 05:04 PM
Fixed. The issue comes from the fact that ITAD bundle imports are forced to work with game names, and sometimes bundle reporters will enter a name that's not on Steam, but it'll find an equivalent in another store, so this'll be used. Meh.

I could add some kind of failsafe to prevent non-Steam games being added without my manual approval, but I like mostly having the thing working without human intervention.
Title: Re: Issue(s)
Post by: /u/humpaaa on April 17th, 2020, 01:21 PM
SSL cert expired again.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on April 19th, 2020, 04:51 PM
Yeah and Devotee is nowhere to be found, again ;)

I always convince myself he's finally automated the renewal, lol... It's just a matter of adding a script.
Title: Re: Issue(s)
Post by: Annoyer13 on April 23rd, 2020, 02:15 PM
I'd recommend cloudflare, adds ssl with no hassle.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on April 24th, 2020, 11:22 AM
Meh, LetsEncrypt does the job just fine and you don't have to go through another server for that.
The only problem is that I can never get to wake devotee up in time for fixing SSL...
Other than that, I could possibly move the server to another place, but I don't want to pay for it, etc.
It's not a project that earns me anything (either glory or fortune), and I added the server to my 'exception list' long ago (so that I wouldn't get SSL error notifications), so I don't know what else to say... Add to your exceptions? Or try & find a way to get in touch with devotee because I can't ;)
Title: Re: Issue(s)
Post by: Banny on June 4th, 2020, 08:09 PM
Error 302An error occurred while trying to retrieve your Barter blacklist. Please try again!
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 4th, 2020, 09:43 PM
Yeah, as I mentioned in the other topic, it looks like Barter is currently preventing other websites (or just Lestrade's?) from getting data from it.
Someone would have to ask the BVG webmaster to look into it and re-enable outside scraping.
We had this discussion years ago, and settled on a scraping system that was soft on his servers, I can look into making the updates less frequent (it's better than nothing), but if there's no way to get data from BVG, I will no longer be able to connect users between the websites, and make it possible to transfer tradables with tags, etc. Which would be... bad, for both websites (in my opinion).
Title: Re: Issue(s)
Post by: Akylen on June 5th, 2020, 01:04 PM
I've created a discussion here(https://steamcommunity.com/groups/bartervg/discussions/1/2289464808484144826/). Hope it gets his attention :)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 6th, 2020, 02:48 AM
You know, you don't have to convince him, we already had this discussion in the past. ;-)
Our main issue wasn't that I was scraping his database, but rather the fact that he wanted me to use his JSON API instead (which I'm thinking he wrote with me in mind). Which I'd be fine with, but there were always things missing compared to what was being shown on the website. And now in 2020 I don't really see an incentive to start rewriting my codebase anyway. Lestrade's is in maintenance mode, meaning I'm always there to fix it, but I don't even bother to document new features anymore... :-/ (For instance, this week I added a 'release date' field on studio pages, lol. Figured it could help if you're looking through a game series and want to know which one came out first.)
Title: Re: Issue(s)
Post by: Akylen on June 6th, 2020, 02:47 PM
Just wanted to add in there that I think both platforms are useful for different purposes. As I said, I hope this is just some bug in the system
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 7th, 2020, 12:27 PM
Yeah, although I still think Lestrade's is the most 'usable' trading system because it's more open (for instance you can send multiple offers to a single person), faster (AJAX everywhere, especially when adding and removing games to an offer), and clearer (the 'lock' icon to make a game mandatory in a multiple-choice offer), Barter clearly won with its number of users (which ultimately is the only thing that matters, isn't it? That the majority is making their life harder is irrelevant), so I'm doing most of my trades at Barter now, and enjoying the fact that its webmaster has been backporting Lestrade's features over there over the years. I believe recently he added the lock system, too, although I haven't used it yet. It's just a shame that when you do something at barter, it always takes 3 more clicks and 10 more seconds than the same operation at Lestrade's... Editing tradable tags? It has gotten better at BVG (you can now do it from a game page, thankfully), but it requires unnecessary clicking (why do I have to check a box next to a tradable before I can edit it? Why do I have to confirm tags one by one when he could add a multi-checkbox list instead?).
Anyway, at this point, I use Barter for trading mostly, and Lestrade's for the rest:
- maintaining my tradable list (then exporting it to Barter, excluding my 'may keeps' which I'm reserving for Lestrade's),
- maintaining my library (including fixing playtimes so that card farming time isn't taken into account),
- searching for games (it's so easy, and I can't tell you the number of games I found just because the search engine also looked inside game descriptions! Which as far as I know, is the only Steam search engine to do so!),
- looking at ITAD bundles (I'm aware that Barter now has much better support for bundles, but I'm not planning to scrape them for now, and since this is the only feature I still have to 'fix' manually from time to time, it's also the only feature that keeps me maintaining the website on a regular basis),
- discussions (the BVG Steam community isn't exactly practical to use...)
- commenting on games and bundles (rarely, but it's still something BVG doesn't have),
- just enjoying the slick layout and fast performance overall...

I couldn't live without Lestrade's, even without trading.
That's why I don't understand why Google is actively preventing search results from showing Lestrade's pages (just like it's pretty impossible to find pages for many of my websites -- for instance ency.cyna.fr has a valuable database of artists for the Saint Seiya show, but typing an artist's name followed by 'ency.cyna.fr' into Google NEVER shows a relevant result!), I find it really sad. (Maybe Google has banned me for using Bing for about 5 minutes back in 2007 or so..?)
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 7th, 2020, 12:34 PM
Note: I just read a bit more about error 302 and it looks like it might be a redirection problem. I'll look into it. Maybe it's a bug the webmaster didn't plan on 'introducing'. So far I've been scraping from his requested URL (which isn't the public-facing URL.)
Title: Re: Issue(s)
Post by: Akylen on June 7th, 2020, 01:11 PM
I agree with most of what you said. Lestrades is generally better with a few nuances:
* Steam bundle pages sometimes contain games that are not linked to the steam version
* Search sometimes gets confused with certain characters and it is impossible to find them. I have to use barter and link to here. Sometimes it actually tikes a bit long and becomes frustrating (although rarely).
Don't worry, I understand you don't have time to make the changes.
Features here are certainly better here, than even the steam website. Incredible on how much money they have, and certain basic features are still poor compared to the rest.

Since Barter has the user base, they can copy features from here to grow even further. It is unfair, but that's how the world works. That is why having monopolies is really bad. Companies buying/destroying smaller companies, and becoming bigger and bigger. Of course I am exaggerating here, but without some kind of incentive users don't do shit to change their habits. This happens to every individual in any part of life. Change is hard :/
In terms of community, I don't see a problem having theirs on Steam, but would be nice to have a more broader approach to support other platforms.

If I were to choose which one I'd want, I'd choose Lestrades, because it makes my life so much easier. I'm sure the issues above could be resolved swiftly.
Besides the user base from Barter would move here, as there is no other option.

As for the last point, I stopped using google long time ago when I saw they hide links on purpose, and I'm not talking just about piracy, or porn, whatever, but things that are related to freedom of speech, specially if it is something bad about them. Thus I use duckduckgo.
But in order for people to find this website, unfortunately it will have to be found by google. It seems you are in need of some SEO.

This is a point for another discussion, but people should understand that Google and certain other companies have too much power over the internet and the user.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 7th, 2020, 01:27 PM
Okay guys, you can delete the thread over at the BVG Steam community!
The problem was with a configuration issue on this server!
I'm working on a fix.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 7th, 2020, 02:21 PM
The problem should be fixed, although it's a temporary one. @Akylen please don't forget to delete your thread!
I apologize about this issue. @devotee was supposed to fix all configuration issues with the server, but this one clearly is problematic. I'm a bit tired of it, honestly...
Title: Re: Issue(s)
Post by: Akylen on June 7th, 2020, 06:45 PM
Quote from [Lestrades.com]Nao 尚 on June 7th, 02:21 PM
The problem should be fixed, although it's a temporary one. @Akylen please don't forget to delete your thread!
I apologize about this issue. @devotee was supposed to fix all configuration issues with the server, but this one clearly is problematic. I'm a bit tired of it, honestly...
Done. I don't know how to close it, so I deleted it :/
Title: Re: Issue(s)
Post by: AJ on June 9th, 2020, 12:43 AM
Does anybody has the problem can't sync the newly added Origin's titles from the Wishlist on Steam?
Right now, I have 6 titles can't add into the Lestrade's Wishlist and when I sync the Wishlist from Barter.vg it shows no problem though I have that 6 titles on it.

The 6 titles are:
Mirror's Edge Catalyst
Need for Speed
Need for Speed Heat
Need for Speed Rivals
Burnout Paradise Remastered
Crysis 3

[EDIT]: Problem solved somehow now.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 15th, 2020, 05:17 PM
My fix for Barter issues was only partial; I made it more solid a few days after. I don't know if it impacted you.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 16th, 2020, 04:12 PM
And here we are again, the SSL certificates expired... I'm really sick of it.
I'll probably move to a new server soon. I'll have to see. Meh. This isn't what I need right now, the extra workload...
Title: Re: Issue(s)
Post by: Akylen on June 16th, 2020, 05:53 PM
Lets Encrypt made it so easy, I am not sure why the problem still persists. It is quite easy to setup ;)
Title: Re: Issue(s)
Post by: devotee on June 16th, 2020, 08:41 PM
Quote from [Lestrades.com]Nao 尚 on June 7th, 02:21 PM
The problem should be fixed, although it's a temporary one. @Akylen please don't forget to delete your thread!
I apologize about this issue. @devotee was supposed to fix all configuration issues with the server, but this one clearly is problematic. I'm a bit tired of it, honestly...
I haven't touched anything on the server so if something suddenly stopped working, it's not because an issue with it.
Quote from Akylen on June 16th, 05:53 PM
Lets Encrypt made it so easy, I am not sure why the problem still persists. It is quite easy to setup ;)
It seems that the certificate is renewed correctly but the apache daemon is not restarted when the certificate is renewed. However, there's a logrotate task every night that should restart the apache process when rotating the logs. Manually restarting apache does the trick, waiting for the next logrotate should also work but I haven't checked it.

I would really like to upgrade the server to the latest Debian release but you should expect some downtime with it. I'm also not sure it it's worth waiting for the next Debian release (I don't really know if it's going to be released, according to the Debian version history it should be sometime in 2021).
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 17th, 2020, 12:26 AM
I'm all for a server update. Feel free.
Maybe it'll finally fix all the SSL problems. As I mentioned earlier, even cURL no longer works in the current setup when SSL is explicitly enabled. I've had to rely on file_get_contents instead, Which is less secure. (Although in my case, I'm only retrieving public data and not disclosing any sensitive information during the handshake, so it's not a problem per se, just something I'd rather not do as a proper web developer.)
Title: Re: Issue(s)
Post by: Akylen on June 17th, 2020, 12:59 PM
Quote from [Lestrades.com]Nao 尚 on June 17th, 12:26 AM
I'm all for a server update. Feel free.
Maybe it'll finally fix all the SSL problems. As I mentioned earlier, even cURL no longer works in the current setup when SSL is explicitly enabled. I've had to rely on file_get_contents instead, Which is less secure. (Although in my case, I'm only retrieving public data and not disclosing any sensitive information during the handshake, so it's not a problem per se, just something I'd rather not do as a proper web developer.)
curl should work in those cases with the '--insecure' flag
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 17th, 2020, 06:55 PM
Well, I don't know, it's not working for me when disabling secure flags. Also, your flag format is for a command line call, I'm using PHP functions for that. ;)
Title: Re: Issue(s)
Post by: devotee on June 17th, 2020, 08:46 PM
curl is working with SSL sites system-wide using the command line executable, maybe it's the php5-curl package that needs an upgrade so the certificates included are up to date.

I think you can pass options to curl in php using curl_setopt. According to this(https://stackoverflow.com/questions/15232977/php-curl-k-or-insecure-x) it would be:

Code: [Select]
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);

What's the error you're getting when using curl in php? This(https://thisinterestsme.com/php-curl-ssl-certificate-error/) might also work.
Title: Re: Issue(s)
Post by: [Lestrades.com] Nao 尚 on June 18th, 2020, 12:01 AM
I tried using false earlier, but it failed to work as well. (I also tried variations involving VERIFYHOST and FORBID_REUSE.)
Maybe now it'd work because you renewed the certificate, but I'm not sure I'll take any chances. ;)