Lestrade's

Lestrade's Lounge => The Fatal Problem => Topic started by: nhex on December 22nd, 2017, 11:50 PM

Title: Can't send offers
Post by: nhex on December 22nd, 2017, 11:50 PM
Not sure why it's not working, but I click "Send Offer" and it looks like it sends but it doesn't...
Title: Re: Can't send offers
Post by: [Lestrades.com] Nao 尚 on December 24th, 2017, 01:21 AM
I'm not seeing any issues on my side, and given that there have been no other complaints about it today (forgot to check out the forum, as I was busy working on more 'dlc to episode' conversions, I HATE THE STEAM DATABASE!!! Now 7500 movies & show episodes in it!), I suspect it was a problem on your side...?
Can you try again?
Title: Re: Can't send offers
Post by: nhex on December 24th, 2017, 01:41 AM
Yeah, same problem... anything I can look at or check to help debug this?
Title: Re: Can't send offers
Post by: [Lestrades.com] Nao 尚 on December 24th, 2017, 03:08 PM
Well I don't know, when I click "Send Offer" I get redirected to the final offer, with 'edit' and 'cancel' buttons on it.
What happens when you click it? Does it load a new page? What does it have? The offer creation page or the final offer page?
Title: Re: Can't send offers
Post by: nhex on December 24th, 2017, 04:43 PM
I click Send Offer, the offer "disappears" in the page for a second, then it reappears
Title: Re: Can't send offers
Post by: [Lestrades.com] Nao 尚 on December 24th, 2017, 06:13 PM
Oh... So you mean it behaves like when you click 'Preview'...? @_@

PS: anyone else care to chip in..? I really, really don't want to tweak my code to remove my admin rights on that page.. Yes, I'll do it eventually, but... I still think it's a problem that would be reported by more than one person if it was the same for everyone.
Title: Re: Can't send offers
Post by: /u/humpaaa on December 26th, 2017, 04:40 PM
I did just send a test offer to nhex, worked fine
Title: Re: Can't send offers
Post by: [Lestrades.com] Nao 尚 on December 26th, 2017, 04:59 PM
OK, so I'm not going crazy, thanks... ;)
@nhex, you'll need to provide more details then! Maybe it's a specific browser/OS issue..?
Title: Re: Can't send offers
Post by: nhex on December 26th, 2017, 08:31 PM
Ah ok.  I'm on Mac OS.
It worked in Chrome! But it still is broken in Firefox and Safari. I can live with that though. TY.
Title: Re: Can't send offers
Post by: [Lestrades.com] Nao 尚 on December 27th, 2017, 12:34 AM
Tried Firefox on my Win7, and it worked just the same...

Why would Firefox be broken on Mac?
Safari, I can understand, it's a shit™ browser, but Firefox..?
Title: Re: Can't send offers
Post by: nhex on December 27th, 2017, 08:58 AM
🤷‍♂
Title: Re: Can't send offers
Post by: [Lestrades.com] Nao 尚 on December 27th, 2017, 10:18 AM
I would still need help here. I don't know, do you get any errors in your console when offering?
Title: Re: Can't send offers
Post by: nhex on December 28th, 2017, 11:16 AM
How would I access that in Firefox? I don't see any messages normally.
Title: Re: Can't send offers
Post by: [Lestrades.com] Nao 尚 on December 28th, 2017, 05:45 PM
Right click, Inspect Element, then there's a 'Console' tab to click. Make sure to keep the log (by default, IIRC, it empties the log when you move on to another page, e.g. by clicking on a button.)
Title: Re: Can't send offers
Post by: nhex on December 30th, 2017, 09:30 PM
XML Parsing Error: not well-formed
Location: https://lestrades.com/offer/?u=485
Line Number 9, Column 97:
offer:9:97
XML Parsing Error: not well-formed
Location: https://lestrades.com/offer/?u=485;g=93955,332172
Line Number 9, Column 97:

Repeats those two lines over and over again when I load or click a button
Title: Re: Can't send offers
Post by: [Lestrades.com] Nao 尚 on December 31st, 2017, 01:06 AM
Thanks, can you try again..? I've added an explicit header to turn the Ajax result into plain text, while jQuery for some reason insisted that I was returning XML, even despite my override. Because Firefox has a different parser, it sent you those errors when parsing HTML5 instead of "good old" XHTML.
*Perhaps* that's the reason your request to send offer would fail, but honestly I doubt so... At least, well, at least you won't get these errors now.
Title: Re: Can't send offers
Post by: [Lestrades.com] Nao 尚 on December 31st, 2017, 01:26 PM
Lol, the irony is that I can no longer send offers from my smartphone now. Dunno if it's due to the explicit header thing, I'll look into it when I'm back on my pc.
Title: Re: Can't send offers
Post by: Gelweo on January 1st, 2018, 01:45 PM
Same problem...
Title: Re: Can't send offers
Post by: [Lestrades.com] Nao 尚 on January 2nd, 2018, 03:37 PM
I'm sorry for not being there to fix that earlier... I was just busy with the New Year stuff. (Happy New Year, BTW!)

So, offer sending should now be fixed on all browsers. The issue was quite 'funny', in that setting the content to a plain text type changed the object Ajax sent back to my script-- from an actual object to a simple string. So I was trying to show 'doc.responseText', when actually the end result was just in 'doc' itself.

I've also fixed the search engine on desktop browsers, and made it 'usable' on mobile browsers-- unfortunately you'll have to select an app type FIRST, and then type your desired search string, instead of being able to switch between types as on a desktop browser. There's an alternative, but it ends up hiding the top of the search results box (only a few pixels but I hate this kind of bug), and I'm unable to figure out why there's a problem with the z-index precedence. (Seriously, it's pretty complicated..)
Title: Re: Can't send offers
Post by: [Lestrades.com] Nao 尚 on January 3rd, 2018, 09:36 AM
Quote from Lestrade 尚 on January 2nd, 2018, 03:37 PM
There's an alternative, but it ends up hiding the top of the search results box (only a few pixels but I hate this kind of bug),
BTW, I decided to go with that solution-- the few pixels didn't make any noticeable difference in a mobile context, and it's really more comfortable to use.
Title: Re: Can't send offers
Post by: nhex on January 4th, 2018, 12:55 AM
Still no dice on Firefox/Mac.
Title: Re: Can't send offers
Post by: [Lestrades.com] Nao 尚 on January 4th, 2018, 10:22 AM
Uh really?!
But I've fixed it everywhere else... :(

Can you try this? Select games, click preview, then refresh the page and try to send offer.
Title: Re: Can't send offers
Post by: nhex on January 6th, 2018, 12:17 AM
didn't work. :( I don't know what else you can really do. Thanks for trying though
Title: Re: Can't send offers
Post by: [Lestrades.com] Nao 尚 on January 6th, 2018, 08:46 AM
Please this isn't helping.. at what point in the indicated process did it not work as expected..? Refreshing the page should be loading the items requested, as the url is being updated with them...